You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "s7monk (via GitHub)" <gi...@apache.org> on 2024/06/03 19:22:14 UTC
[PR] [Improvement][UI] Optimize the display position of option page fields [paimon-webui]
s7monk opened a new pull request, #300:
URL: https://github.com/apache/paimon-webui/pull/300
close: https://github.com/apache/paimon-webui/issues/299
### Purpose
Optimize the display position of option page fields.
Before:
After:
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][UI] Optimize the display position of option page fields [paimon-webui]
Posted by "zhangmo8 (via GitHub)" <gi...@apache.org>.
zhangmo8 commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1626022361
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
You just need to keep this sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Optimize the display position of option page fields [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1628559008
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
done,I have used the justify property of Space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Optimize the display position of option page fields [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #300:
URL: https://github.com/apache/paimon-webui/pull/300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Optimize the display position of option page fields [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1628565562
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
If no additional styles are used for the title, there will be no margin with the right border, as shown below：
After adding style：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][UI] Optimize the display position of option page fields [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1626140862
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
I tried align: 'right', but the title just moved to the far right and stuck to the right border, but the action buttons below did not move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][UI] Optimize the display position of option page fields [paimon-webui]
Posted by "zhangmo8 (via GitHub)" <gi...@apache.org>.
zhangmo8 commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1626843197
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
this Space component has the `justify` props
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Optimize the display position of option page fields [paimon-webui]
Posted by "zhangmo8 (via GitHub)" <gi...@apache.org>.
zhangmo8 commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1628675516
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
I just think it is unreasonable to choose to write your own style instead of using the relevant props provided by the component.
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
If you add this padding, the distance from key to the left is not the same as the distance from operation to the right. I think both are fine. In addition, I don't think any users will pay attention to whether the right side is too close, if any, pr welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement] Optimize the display position of option page fields [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1628978545
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org