[kudu-CR] Add unique id generation to the client

["Adar Dembo (Code Review)" <ge...@cloudera.org>]

Adar Dembo has posted comments on this change.

Change subject: Add unique id generation to the client
......................................................................


Patch Set 11:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/client/client_builder-internal.cc
File src/kudu/client/client_builder-internal.cc:

Line 26:     default_rpc_timeout_(MonoDelta::FromSeconds(10)) {}
Can you revert this change? It's just unnecessary noise.


http://gerrit.cloudera.org:8080/#/c/3077/11/src/kudu/integration-tests/client-stress-test.cc
File src/kudu/integration-tests/client-stress-test.cc:

Line 42: namespace client {
Hmm, while the test is called client-stress-test, it's part of the integration-tests module, so I don't know if it should be in the client namespace (which I'd expect for things in the client module). Why did you need to make this change?


Line 49: class ClientStressTest: public KuduTest {
This syntax is quite a bit more rare in the Kudu codebase than the original syntax. Could you revert it? Below too.


Line 279:                  << total_num_rejections << " memory rejections";
The old indentation was nicer, I think.


-- 
To view, visit http://gerrit.cloudera.org:8080/3077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie752ab8337cc76c3be1536958c24a8b6c5794650
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes