You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/08/01 16:20:27 UTC
[PR] Prepare upgrade to Gradle 9 [polaris]
snazy opened a new pull request, #2237:
URL: https://github.com/apache/polaris/pull/2237
* `shadowPub.kt` the change removes a special case that doesn't apply to Polaris
* `api/...` build scripts - changes due to nullable type handling (`Property<String>` vs `Property<String?>` - latter is ... weird)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare upgrade to Gradle 9 [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #2237:
URL: https://github.com/apache/polaris/pull/2237#discussion_r2248381123
##########
api/management-model/build.gradle.kts:
##########
@@ -50,13 +50,13 @@ val generatedOpenApiSrcDir = project.layout.buildDirectory.dir("generated-openap
openApiGenerate {
// The OpenAPI generator does NOT resolve relative paths correctly against the Gradle project
// directory
- inputSpec = specsDir.file("polaris-management-service.yml").asFile.absolutePath
+ inputSpec = provider { specsDir.file("polaris-management-service.yml").asFile.absolutePath }
generatorName = "jaxrs-resteasy"
- outputDir = generatedDir.get().asFile.absolutePath
+ outputDir = provider { generatedDir.get().asFile.absolutePath }
modelPackage = "org.apache.polaris.core.admin.model"
- ignoreFileOverride = rootDir.file(".openapi-generator-ignore").asFile.absolutePath
- removeOperationIdPrefix = true
- templateDir = templatesDir.asFile.absolutePath
+ ignoreFileOverride.set(provider { rootDir.file(".openapi-generator-ignore").asFile.absolutePath })
Review Comment:
This is because the property's declared as `Property<String?>` by the plugin extension. It doesn't make sense to declare nullable values as `Property`s - it has a value or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prepare upgrade to Gradle 9 [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #2237:
URL: https://github.com/apache/polaris/pull/2237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org