You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sa...@apache.org> on 2016/12/09 21:46:49 UTC
Re: Review Request 54558: GEODE-523: PartitionListener requires tests
and clean up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54558/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 1:46 p.m.)
Review request for geode, Darrel Schneider and Dan Smith.
Bugs: GEODE-523
https://issues.apache.org/jira/browse/GEODE-523
Repository: geode
Description
-------
* Updated javadoc to remove support language and to update example
* Added tests to cover that methods
PS: I had to flip the assert for vm3 `afterPrimary` verification, may be due to rebalancing the list of current primaries may not be same as list of callbacks ever invoked on the VM. Some buckets might become secondaries after being primaries during the course of rebalancing. So my testing showed flipping the assert is deterministic. It was never the case for asserting vm1, vm2 `afterPrimary` lists as those asserts were prior to rebalancing.
Diffs
-----
geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java 2a79459
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java 16bac77
Diff: https://reviews.apache.org/r/54558/diff/
Testing
-------
precheckin
Thanks,
Sai Boorlagadda
Re: Review Request 54558: GEODE-523: PartitionListener requires tests
and clean up
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54558/#review158901
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Dec. 9, 2016, 9:46 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54558/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 9:46 p.m.)
>
>
> Review request for geode, Darrel Schneider and Dan Smith.
>
>
> Bugs: GEODE-523
> https://issues.apache.org/jira/browse/GEODE-523
>
>
> Repository: geode
>
>
> Description
> -------
>
> * Updated javadoc to remove support language and to update example
> * Added tests to cover that methods
>
> PS: I had to flip the assert for vm3 `afterPrimary` verification, may be due to rebalancing the list of current primaries may not be same as list of callbacks ever invoked on the VM. Some buckets might become secondaries after being primaries during the course of rebalancing. So my testing showed flipping the assert is deterministic. It was never the case for asserting vm1, vm2 `afterPrimary` lists as those asserts were prior to rebalancing.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java 2a79459
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java 16bac77
>
> Diff: https://reviews.apache.org/r/54558/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Sai Boorlagadda
>
>
Re: Review Request 54558: GEODE-523: PartitionListener requires tests
and clean up
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54558/#review158878
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Dec. 9, 2016, 1:46 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54558/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 1:46 p.m.)
>
>
> Review request for geode, Darrel Schneider and Dan Smith.
>
>
> Bugs: GEODE-523
> https://issues.apache.org/jira/browse/GEODE-523
>
>
> Repository: geode
>
>
> Description
> -------
>
> * Updated javadoc to remove support language and to update example
> * Added tests to cover that methods
>
> PS: I had to flip the assert for vm3 `afterPrimary` verification, may be due to rebalancing the list of current primaries may not be same as list of callbacks ever invoked on the VM. Some buckets might become secondaries after being primaries during the course of rebalancing. So my testing showed flipping the assert is deterministic. It was never the case for asserting vm1, vm2 `afterPrimary` lists as those asserts were prior to rebalancing.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java 2a79459
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionListenerDUnitTest.java 16bac77
>
> Diff: https://reviews.apache.org/r/54558/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Sai Boorlagadda
>
>