[GitHub] [superset] betodealmeida commented on a change in pull request #17740: fix: dataset extra import/export

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #17740:
URL: https://github.com/apache/superset/pull/17740#discussion_r774040963



##########
File path: superset/datasets/commands/importers/v1/utils.py
##########
@@ -98,7 +98,7 @@ def import_dataset(
     for key in ("metrics", "columns"):
         for attributes in config.get(key, []):
             # should be a dictionary, but in initial exports this was a string
-            if isinstance(attributes.get("extra"), dict):
+            if attributes.get("extra") is not None:

Review comment:
       Oh, good catch, the comment is stale.

##########
File path: superset/datasets/commands/importers/v1/utils.py
##########
@@ -98,7 +98,7 @@ def import_dataset(
     for key in ("metrics", "columns"):
         for attributes in config.get(key, []):
             # should be a dictionary, but in initial exports this was a string

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org