You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2025/02/14 11:50:58 UTC

[PR] fix: ghac doesn't support delete anymore [opendal]

Xuanwo opened a new pull request, #5628:
URL: https://github.com/apache/opendal/pull/5628

   # Which issue does this PR close?
   
   Part of https://github.com/apache/opendal/issues/5621
   
   # Rationale for this change
   
   All deleted related tests are failed for ghac now.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking-changes` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: ghac doesn't support delete anymore [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5628:
URL: https://github.com/apache/opendal/pull/5628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: ghac doesn't support delete anymore [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #5628:
URL: https://github.com/apache/opendal/pull/5628#discussion_r1956115698


##########
.github/workflows/service_test_ghac.yml:
##########
@@ -59,7 +59,7 @@ jobs:
       - name: Test
         shell: bash
         working-directory: core
-        run: cargo nextest run behavior --features tests,services-ghac
+        run: cargo test behavior --features tests,services-ghac

Review Comment:
   Nextest relies on `path/to/test/binary list` to enumerate all test cases. If any logs are output at this stage, it will refuse to run.
   
   Output likes:
   
   ```shell
   error: creating test list failed
   
   Caused by:
     for `opendal::behavior`, line '  2025-02-14T11:57:30.185063Z DEBUG opendal::services: service=ghac name=opendal: metadata started' did not end with the string ': test' or ': benchmark'
   full output:
   behavior::test_read_full: test
   behavior::test_read_range: test
   behavior::test_reader: test
   behavior::test_reader_with_if_match: test
   behavior::test_reader_with_if_none_match: test
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: ghac doesn't support delete anymore [opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #5628:
URL: https://github.com/apache/opendal/pull/5628#discussion_r1956097698


##########
.github/workflows/service_test_ghac.yml:
##########
@@ -59,7 +59,7 @@ jobs:
       - name: Test
         shell: bash
         working-directory: core
-        run: cargo nextest run behavior --features tests,services-ghac
+        run: cargo test behavior --features tests,services-ghac

Review Comment:
   May I ask what's the rationale here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org