Re: Review Request: Fix the cgroups tests so that the memory blow up is more robust.

[Vinod Kone <vi...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6867/#review11128
-----------------------------------------------------------



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/6867/#comment23851>

    from the manpage, http://pubs.opengroup.org/onlinepubs/7908799/xsh/valloc.html, looks like valloc is not the preferred way?



src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/6867/#comment23852>

    isn't this redundant now after mlock?



src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/6867/#comment23853>

    ditto


- Vinod Kone


On Aug. 31, 2012, 4:49 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6867/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 4:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Make memory blow up more robust. Seems that the newest kernel has a more smart way to do page replacement, which makes our previous memory blow up strategy not working.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_executor.cpp 60be806 
>   src/tests/cgroups_tests.cpp 0c56481 
>   src/tests/external/CgroupsIsolation/ROOT_CGROUPS_BalloonFramework.sh c5c5931 
> 
> Diff: https://reviews.apache.org/r/6867/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>