You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/05/26 02:38:25 UTC

svn commit: r1597496 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java

Author: mattsicker
Date: Mon May 26 00:38:25 2014
New Revision: 1597496

URL: http://svn.apache.org/r1597496
Log:
Don't try to do type conversion on @PluginValue.

  - These are always strings, so it's pointless to do conversion.

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java?rev=1597496&r1=1597495&r2=1597496&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/util/PluginBuilder.java Mon May 26 00:38:25 2014
@@ -193,7 +193,7 @@ public class PluginBuilder<T> {
                     final String name = ((PluginValue) a).value();
                     final String v = node.getValue() != null ? node.getValue() : getAttrValue("value");
                     final String value = configuration.getStrSubstitutor().replace(event, v);
-                    args[i] = TypeConverters.convert(value, types[i], defaultValue);
+                    args[i] = value;
                     sb.append(name).append("=\"").append(value).append('"');
                 } else if (a instanceof PluginAttribute) {
                     final PluginAttribute attribute = (PluginAttribute) a;