You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jean-Daniel Cryans <jd...@apache.org> on 2010/10/29 01:42:26 UTC

Review Request: Tool to verify data in two clusters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1111/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

This new mapreduce job called VerifyReplication compares the data between two clusters that are replication-enabled. Its usage is relatively simple when you already use replication, and even let's you pass the peer id instead of the cluster key for the target cluster.


This addresses bug HBASE-3013.
    http://issues.apache.org/jira/browse/HBASE-3013


Diffs
-----

  /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java 1028470 
  /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java PRE-CREATION 
  /trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java 1028470 
  /trunk/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 1028470 

Diff: http://review.cloudera.org/r/1111/diff


Testing
-------

Unit test (one new included) and this has been running for a month here.


Thanks,

Jean-Daniel


Re: Review Request: Tool to verify data in two clusters

Posted by Jean-Daniel Cryans <jd...@apache.org>.

> On 2010-10-28 16:52:20, stack wrote:
> > Excellent.  Minor items to address on commit.  So, is this new fancy tool doc'd in replication notes?  I think it kinda critical.  Would suggest opening a doc issue against 0.90 to mention presence of this tool in the replication chapter.... if only a sentence.

Thanks for the comments, integrating them. I'll add a note in the replication documentation for the website.


- Jean-Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1111/#review1693
-----------------------------------------------------------


On 2010-10-28 16:42:25, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1111/
> -----------------------------------------------------------
> 
> (Updated 2010-10-28 16:42:25)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This new mapreduce job called VerifyReplication compares the data between two clusters that are replication-enabled. Its usage is relatively simple when you already use replication, and even let's you pass the peer id instead of the cluster key for the target cluster.
> 
> 
> This addresses bug HBASE-3013.
>     http://issues.apache.org/jira/browse/HBASE-3013
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java 1028470 
>   /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java PRE-CREATION 
>   /trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java 1028470 
>   /trunk/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 1028470 
> 
> Diff: http://review.cloudera.org/r/1111/diff
> 
> 
> Testing
> -------
> 
> Unit test (one new included) and this has been running for a month here.
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Re: Review Request: Tool to verify data in two clusters

Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1111/#review1693
-----------------------------------------------------------

Ship it!


Excellent.  Minor items to address on commit.  So, is this new fancy tool doc'd in replication notes?  I think it kinda critical.  Would suggest opening a doc issue against 0.90 to mention presence of this tool in the replication chapter.... if only a sentence.


/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
<http://review.cloudera.org/r/1111/#comment5603>

    Missing '<p>' here?



/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
<http://review.cloudera.org/r/1111/#comment5602>

    Space around the '+'



/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
<http://review.cloudera.org/r/1111/#comment5604>

    Put this in Result?


- stack


On 2010-10-28 16:42:25, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1111/
> -----------------------------------------------------------
> 
> (Updated 2010-10-28 16:42:25)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This new mapreduce job called VerifyReplication compares the data between two clusters that are replication-enabled. Its usage is relatively simple when you already use replication, and even let's you pass the peer id instead of the cluster key for the target cluster.
> 
> 
> This addresses bug HBASE-3013.
>     http://issues.apache.org/jira/browse/HBASE-3013
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java 1028470 
>   /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java PRE-CREATION 
>   /trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java 1028470 
>   /trunk/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 1028470 
> 
> Diff: http://review.cloudera.org/r/1111/diff
> 
> 
> Testing
> -------
> 
> Unit test (one new included) and this has been running for a month here.
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>