You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/10/11 23:16:33 UTC
[jira] [Commented] (THRIFT-2783) Correctly propagate binary
encoding of WebSocket frames Node.js library
[ https://issues.apache.org/jira/browse/THRIFT-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168341#comment-14168341 ]
Hudson commented on THRIFT-2783:
--------------------------------
SUCCESS: Integrated in Thrift #1309 (See [https://builds.apache.org/job/Thrift/1309/])
THRIFT-2783:Prop bin encoding in node (ra: rev 1107b17ae4bcfbdb7fb485f026da95ceb6079311)
* lib/nodejs/lib/thrift/web_server.js
> Correctly propagate binary encoding of WebSocket frames Node.js library
> -----------------------------------------------------------------------
>
> Key: THRIFT-2783
> URL: https://issues.apache.org/jira/browse/THRIFT-2783
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Reporter: John Campbell
> Assignee: Randy Abernethy
> Priority: Minor
> Fix For: 0.9.2
>
> Attachments: thrift-2783-nodejs-fix-websocket-binencoding.patch
>
>
> The node.js library isn't correctly propagating the binary encoding of the WebSocket frame. While not fully implemented yet, this creates problems for a browser javascript implementation TBinaryProtocol/TCompactProtocol/etc.
> Please see attached patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)