You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "pfyra (via GitHub)" <gi...@apache.org> on 2023/10/02 06:46:39 UTC

[GitHub] [mynewt-nimble] pfyra commented on a diff in pull request #1591: porting/npl/freertos: Add way of including HW specific header

pfyra commented on code in PR #1591:
URL: https://github.com/apache/mynewt-nimble/pull/1591#discussion_r1342327256


##########
porting/npl/freertos/src/npl_os_freertos.c:
##########
@@ -22,6 +22,10 @@
 #include <string.h>
 #include "nimble/nimble_npl.h"
 
+#ifdef NIMBLE_NPL_OS_EXTRA_INCLUDE
+#include NIMBLE_NPL_OS_EXTRA_INCLUDE
+#endif
+

Review Comment:
   Certainly. I have added a comment now and I tried to keep it short but descriptive. To me, it is borderline obvious that you use this to avoid changes in the code and if other changes are required anyway then I guess people simply won't bother with this. Let me know what you think and I'll update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org