You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Rhett Sutphin (JIRA)" <ji...@apache.org> on 2009/08/26 18:21:59 UTC

[jira] Created: (BUILDR-304) Referencing an existing package task using the package method fails if the package has a custom filename

Referencing an existing package task using the package method fails if the package has a custom filename
--------------------------------------------------------------------------------------------------------

                 Key: BUILDR-304
                 URL: https://issues.apache.org/jira/browse/BUILDR-304
             Project: Buildr
          Issue Type: Bug
          Components: Core features
    Affects Versions: 1.3.4, 1.3.3
         Environment: Any
            Reporter: Rhett Sutphin


With a project definition like this:

define 'foo' do
  package(:jar, :file => 'custom.jar')
end

attempting to refer to the defined package via project('foo').package(:jar) fails -- buildr creates a new package task instead.  See this thread for more discussion and the fix:

http://markmail.org/search/?q=Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id#query:Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id+page:1+mid:q7vjuhly2v6lwhru+state:results

Per the discussion, I'll provide a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BUILDR-304) Referencing an existing package task using the package method fails if the package has a custom filename

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Assaf Arkin resolved BUILDR-304.
--------------------------------

    Resolution: Fixed

In Git/SVN.

> Referencing an existing package task using the package method fails if the package has a custom filename
> --------------------------------------------------------------------------------------------------------
>
>                 Key: BUILDR-304
>                 URL: https://issues.apache.org/jira/browse/BUILDR-304
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3, 1.3.4
>         Environment: Any
>            Reporter: Rhett Sutphin
>            Assignee: Assaf Arkin
>         Attachments: 0001-Make-package-jar-accessor-behavior-work-when-the-p.patch
>
>
> With a project definition like this:
> define 'foo' do
>   package(:jar, :file => 'custom.jar')
> end
> attempting to refer to the defined package via project('foo').package(:jar) fails -- buildr creates a new package task instead.  See this thread for more discussion and the fix:
> http://markmail.org/search/?q=Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id#query:Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id+page:1+mid:q7vjuhly2v6lwhru+state:results
> Per the discussion, I'll provide a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-304) Referencing an existing package task using the package method fails if the package has a custom filename

Posted by "Rhett Sutphin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rhett Sutphin updated BUILDR-304:
---------------------------------

    Attachment: 0001-Make-package-jar-accessor-behavior-work-when-the-p.patch

Spec & patch.  

There were a couple of specs in spec/java/packaging_spec which relied on the old behavior.  They are also fixed in this patch.  (They relied on the old behavior, but did not seem to be specifying it.)

The contents of this patch are also in my github fork in the buildr-304 branch:  http://github.com/rsutphin/buildr/tree/buildr-304

> Referencing an existing package task using the package method fails if the package has a custom filename
> --------------------------------------------------------------------------------------------------------
>
>                 Key: BUILDR-304
>                 URL: https://issues.apache.org/jira/browse/BUILDR-304
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3, 1.3.4
>         Environment: Any
>            Reporter: Rhett Sutphin
>         Attachments: 0001-Make-package-jar-accessor-behavior-work-when-the-p.patch
>
>
> With a project definition like this:
> define 'foo' do
>   package(:jar, :file => 'custom.jar')
> end
> attempting to refer to the defined package via project('foo').package(:jar) fails -- buildr creates a new package task instead.  See this thread for more discussion and the fix:
> http://markmail.org/search/?q=Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id#query:Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id+page:1+mid:q7vjuhly2v6lwhru+state:results
> Per the discussion, I'll provide a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (BUILDR-304) Referencing an existing package task using the package method fails if the package has a custom filename

Posted by "Daniel Spiewak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Spiewak reassigned BUILDR-304:
-------------------------------------

    Assignee: Assaf Arkin

> Referencing an existing package task using the package method fails if the package has a custom filename
> --------------------------------------------------------------------------------------------------------
>
>                 Key: BUILDR-304
>                 URL: https://issues.apache.org/jira/browse/BUILDR-304
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3, 1.3.4
>         Environment: Any
>            Reporter: Rhett Sutphin
>            Assignee: Assaf Arkin
>         Attachments: 0001-Make-package-jar-accessor-behavior-work-when-the-p.patch
>
>
> With a project definition like this:
> define 'foo' do
>   package(:jar, :file => 'custom.jar')
> end
> attempting to refer to the defined package via project('foo').package(:jar) fails -- buildr creates a new package task instead.  See this thread for more discussion and the fix:
> http://markmail.org/search/?q=Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id#query:Don%27t%20prepend%20the%20parent%20id%20to%20the%20subproject%20id+page:1+mid:q7vjuhly2v6lwhru+state:results
> Per the discussion, I'll provide a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.