You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "onobc (via GitHub)" <gi...@apache.org> on 2024/11/12 04:01:51 UTC
[PR] Add pulsar-client-reactive-bom module [pulsar-client-reactive]
onobc opened a new pull request, #194:
URL: https://github.com/apache/pulsar-client-reactive/pull/194
This commit introduces a BOM module to make consumption of the library more robust by avoid library version mismatches.
Resolves #193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pulsar-client-reactive-bom module [pulsar-client-reactive]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #194:
URL: https://github.com/apache/pulsar-client-reactive/pull/194#discussion_r1837451526
##########
buildSrc/src/main/groovy/pulsar-client-reactive.library-conventions.gradle:
##########
@@ -19,8 +19,7 @@
plugins {
id 'java-library'
- id 'maven-publish'
- id 'signing'
+ id 'pulsar-client-reactive.publish-conventions'
Review Comment:
> [!NOTE]
> I pulled the publishing piece out into its own plugin as the BOM uses java-platform and the library modules use java-project and they do not play well. Now each user of the publish conventions specifies the `from XYZ` part of the `publications` block.
Messing w/ publishing things can be scary. To easy the fear, I did a `./gradlew pTML` before and after this change and then did a folder compare and made sure the poms and module files were identical before and after. Only the local versions w/ the particular timestamp entry in the files were modified. I am comfortable and confident that this change is not a risk in this regard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pulsar-client-reactive-bom module [pulsar-client-reactive]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc merged PR #194:
URL: https://github.com/apache/pulsar-client-reactive/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pulsar-client-reactive-bom module [pulsar-client-reactive]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #194:
URL: https://github.com/apache/pulsar-client-reactive/pull/194#discussion_r1837451526
##########
buildSrc/src/main/groovy/pulsar-client-reactive.library-conventions.gradle:
##########
@@ -19,8 +19,7 @@
plugins {
id 'java-library'
- id 'maven-publish'
- id 'signing'
+ id 'pulsar-client-reactive.publish-conventions'
Review Comment:
> [!NOTE]
> I pulled the publishing piece out into its own plugin as the BOM uses java-platform and the library modules use java-project and they do not play well. Now each user of the publish conventions specifies the `from XYZ` part of the `publications` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pulsar-client-reactive-bom module [pulsar-client-reactive]
Posted by "onobc (via GitHub)" <gi...@apache.org>.
onobc commented on code in PR #194:
URL: https://github.com/apache/pulsar-client-reactive/pull/194#discussion_r1837450418
##########
README.adoc:
##########
@@ -50,6 +50,82 @@ With Maven:
</dependencies>
----
+[[pulsar-client-reactive-bom]]
Review Comment:
Inspired by our works in Pulsar proper ([here](https://pulsar.apache.org/docs/3.3.x/client-libraries-java-setup/#pulsar-bom)) but minimized a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org