You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/26 18:55:38 UTC
[GitHub] [solr] epugh opened a new pull request, #954: SOLR-16314: fix warnings about method visibility
epugh opened a new pull request, #954:
URL: https://github.com/apache/solr/pull/954
https://issues.apache.org/jira/browse/SOLR-16314
# Description
IntelliJ flagged we use private methods with our `@Before` etc annotations. They do actually get called however.
# Solution
We have a mix of public and private, so lets just use public.
# Tests
Ran tests
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #954: SOLR-16314: fix warnings about method visibility
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #954:
URL: https://github.com/apache/solr/pull/954#issuecomment-1246676110
I don't want to lose the work, so I'm retesting it now and will commit it. And per the discussion on https://lists.apache.org/thread/5k1x8rb67gh2f2kcjqwk3hbbprq9xt2r, will move to fixing the tests package by package instead of "kind of warning by kind of warning" ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #954: SOLR-16314: fix warnings about method visibility
Posted by GitBox <gi...@apache.org>.
epugh merged PR #954:
URL: https://github.com/apache/solr/pull/954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #954: SOLR-16314: fix warnings about method visibility
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on code in PR #954:
URL: https://github.com/apache/solr/pull/954#discussion_r933306494
##########
solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKGEquiv.java:
##########
@@ -103,7 +103,7 @@ public class TestCloudJSONFacetSKGEquiv extends SolrCloudTestCase {
private static final ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
@BeforeClass
- private static void createMiniSolrCloudCluster() throws Exception {
+ public static void createMiniSolrCloudCluster() throws Exception {
// sanity check constants
Review Comment:
```suggestion
// check constants
```
##########
solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKG.java:
##########
@@ -114,7 +114,7 @@ public class TestCloudJSONFacetSKG extends SolrCloudTestCase {
private static final ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
@BeforeClass
- private static void createMiniSolrCloudCluster() throws Exception {
+ public static void createMiniSolrCloudCluster() throws Exception {
// sanity check constants
Review Comment:
```suggestion
// check constants
```
##########
solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetJoinDomain.java:
##########
@@ -88,7 +88,7 @@ public class TestCloudJSONFacetJoinDomain extends SolrCloudTestCase {
private static final ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
@BeforeClass
- private static void createMiniSolrCloudCluster() throws Exception {
+ public static void createMiniSolrCloudCluster() throws Exception {
// sanity check constants
Review Comment:
```suggestion
// check constants
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org