You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Jan van der Lugt (JIRA)" <ji...@apache.org> on 2012/08/15 23:03:38 UTC

[jira] [Created] (AVRO-1140) Buffer.hh includes Config.hh without "../"

Jan van der Lugt created AVRO-1140:
--------------------------------------

             Summary: Buffer.hh includes Config.hh without "../"
                 Key: AVRO-1140
                 URL: https://issues.apache.org/jira/browse/AVRO-1140
             Project: Avro
          Issue Type: Bug
          Components: c++
    Affects Versions: 1.7.1
            Reporter: Jan van der Lugt


Buffer.hh includes the file Config.hh, which is located in the parent directory. Config.hh is included like via #include "Config.hh", but this should be #include "../Config.hh". Both work when compiling the AVRO distribution, but if you install AVRO using make install, g++ complains that it can't find Config.hh, which is included via DataFile.hh in my case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-1140) Buffer.hh includes Config.hh without "../"

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1140:
--------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Verified that the patch works on Mac.

Committed revision 1374938. Thank you Jan van der Lugt.
                
> Buffer.hh includes Config.hh without "../"
> ------------------------------------------
>
>                 Key: AVRO-1140
>                 URL: https://issues.apache.org/jira/browse/AVRO-1140
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>         Attachments: AVRO-1140.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Buffer.hh includes the file Config.hh, which is located in the parent directory. Config.hh is included like via #include "Config.hh", but this should be #include "../Config.hh". Both work when compiling the AVRO distribution, but if you install AVRO using make install, g++ complains that it can't find Config.hh, which is included via DataFile.hh in my case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-1140) Buffer.hh includes Config.hh without "../"

Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437706#comment-13437706 ] 

Thiruvalluvan M. G. commented on AVRO-1140:
-------------------------------------------

Verified that the fix works on Windows (Visual Studio Express 2010) and Cygwin
                
> Buffer.hh includes Config.hh without "../"
> ------------------------------------------
>
>                 Key: AVRO-1140
>                 URL: https://issues.apache.org/jira/browse/AVRO-1140
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>         Attachments: AVRO-1140.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Buffer.hh includes the file Config.hh, which is located in the parent directory. Config.hh is included like via #include "Config.hh", but this should be #include "../Config.hh". Both work when compiling the AVRO distribution, but if you install AVRO using make install, g++ complains that it can't find Config.hh, which is included via DataFile.hh in my case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-1140) Buffer.hh includes Config.hh without "../"

Posted by "Jan van der Lugt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan van der Lugt updated AVRO-1140:
-----------------------------------

    Attachment: AVRO-1140.patch
    
> Buffer.hh includes Config.hh without "../"
> ------------------------------------------
>
>                 Key: AVRO-1140
>                 URL: https://issues.apache.org/jira/browse/AVRO-1140
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>         Attachments: AVRO-1140.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Buffer.hh includes the file Config.hh, which is located in the parent directory. Config.hh is included like via #include "Config.hh", but this should be #include "../Config.hh". Both work when compiling the AVRO distribution, but if you install AVRO using make install, g++ complains that it can't find Config.hh, which is included via DataFile.hh in my case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-1140) Buffer.hh includes Config.hh without "../"

Posted by "Jan van der Lugt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan van der Lugt updated AVRO-1140:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> Buffer.hh includes Config.hh without "../"
> ------------------------------------------
>
>                 Key: AVRO-1140
>                 URL: https://issues.apache.org/jira/browse/AVRO-1140
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.1
>            Reporter: Jan van der Lugt
>         Attachments: AVRO-1140.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Buffer.hh includes the file Config.hh, which is located in the parent directory. Config.hh is included like via #include "Config.hh", but this should be #include "../Config.hh". Both work when compiling the AVRO distribution, but if you install AVRO using make install, g++ complains that it can't find Config.hh, which is included via DataFile.hh in my case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira