You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2009/05/15 09:33:57 UTC

svn commit: r775047 - in /directory/studio/trunk: connection-core/src/main/java/org/apache/directory/studio/connection/core/event/ connection-ui/src/main/java/org/apache/directory/studio/connection/ui/ ldapbrowser-core/src/main/java/org/apache/director...

Author: seelmann
Date: Fri May 15 07:33:57 2009
New Revision: 775047

URL: http://svn.apache.org/viewvc?rev=775047&view=rev
Log:
Removed unnecessary type parameter, updated Javadoc

Modified:
    directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/ConnectionEventRegistry.java
    directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/CoreEventRunner.java
    directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnable.java
    directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnableFactory.java
    directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunner.java
    directory/studio/trunk/connection-ui/src/main/java/org/apache/directory/studio/connection/ui/UiThreadEventRunner.java
    directory/studio/trunk/ldapbrowser-core/src/main/java/org/apache/directory/studio/ldapbrowser/core/events/EventRegistry.java

Modified: directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/ConnectionEventRegistry.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/ConnectionEventRegistry.java?rev=775047&r1=775046&r2=775047&view=diff
==============================================================================
--- directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/ConnectionEventRegistry.java (original)
+++ directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/ConnectionEventRegistry.java Fri May 15 07:33:57 2009
@@ -178,9 +178,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -204,9 +204,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -230,9 +230,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -256,9 +256,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -282,9 +282,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -308,9 +308,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -334,9 +334,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -360,9 +360,9 @@
     {
         EventRunnableFactory<ConnectionUpdateListener> factory = new EventRunnableFactory<ConnectionUpdateListener>()
         {
-            public EventRunnable<ConnectionUpdateListener> createEventRunnable( final ConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final ConnectionUpdateListener listener )
             {
-                return new EventRunnable<ConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -437,7 +437,7 @@
                 EventRunner runner = clone.get( listener );
                 synchronized ( lock )
                 {
-                    EventRunnable<L> runnable = factory.createEventRunnable( listener );
+                    EventRunnable runnable = factory.createEventRunnable( listener );
                     runner.execute( runnable );
                 }
             }

Modified: directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/CoreEventRunner.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/CoreEventRunner.java?rev=775047&r1=775046&r2=775047&view=diff
==============================================================================
--- directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/CoreEventRunner.java (original)
+++ directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/CoreEventRunner.java Fri May 15 07:33:57 2009
@@ -36,7 +36,7 @@
      * This implementation executes the given {@link EventRunnable} within
      * the current thread.
      */
-    public void execute( EventRunnable<?> runnable )
+    public void execute( EventRunnable runnable )
     {
         runnable.run();
     }

Modified: directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnable.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnable.java?rev=775047&r1=775046&r2=775047&view=diff
==============================================================================
--- directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnable.java (original)
+++ directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnable.java Fri May 15 07:33:57 2009
@@ -22,14 +22,12 @@
 
 
 /**
- * The <code>EventRunnable</code> interface should be implemented by any
- * class whose instances are intended to be executed by an {@link EventRunner}.
- * The class must define a method of no arguments called <code>run</code>.
- * <p>
+ * An <code>EventRunnable</code> is used to notify a listener
+ * about an event.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
-public interface EventRunnable<T> extends Runnable
+public interface EventRunnable extends Runnable
 {
 }

Modified: directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnableFactory.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnableFactory.java?rev=775047&r1=775046&r2=775047&view=diff
==============================================================================
--- directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnableFactory.java (original)
+++ directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunnableFactory.java Fri May 15 07:33:57 2009
@@ -22,15 +22,20 @@
 
 
 /**
- * The <code>EventRunnable</code> interface should be implemented by any
- * class whose instances are intended to be executed by an {@link EventRunner}.
- * The class must define a method of no arguments called <code>run</code>.
- * <p>
+ * Factory to create {@link EventRunnable} objects.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
 public interface EventRunnableFactory<L>
 {
-    EventRunnable<L> createEventRunnable( L listener );
+    
+    /**
+     * Creates a new {@link EventRunnable} object.
+     * 
+     * @param listener the listener receiving the event notification
+     * 
+     * @return the {@link EventRunnable} object
+     */
+    EventRunnable createEventRunnable( L listener );
 }

Modified: directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunner.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunner.java?rev=775047&r1=775046&r2=775047&view=diff
==============================================================================
--- directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunner.java (original)
+++ directory/studio/trunk/connection-core/src/main/java/org/apache/directory/studio/connection/core/event/EventRunner.java Fri May 15 07:33:57 2009
@@ -34,6 +34,6 @@
      *
      * @param runnable the event runnable to run
      */
-    public void execute( EventRunnable<?> runnable );
+    public void execute( EventRunnable runnable );
 
 }

Modified: directory/studio/trunk/connection-ui/src/main/java/org/apache/directory/studio/connection/ui/UiThreadEventRunner.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/connection-ui/src/main/java/org/apache/directory/studio/connection/ui/UiThreadEventRunner.java?rev=775047&r1=775046&r2=775047&view=diff
==============================================================================
--- directory/studio/trunk/connection-ui/src/main/java/org/apache/directory/studio/connection/ui/UiThreadEventRunner.java (original)
+++ directory/studio/trunk/connection-ui/src/main/java/org/apache/directory/studio/connection/ui/UiThreadEventRunner.java Fri May 15 07:33:57 2009
@@ -40,7 +40,7 @@
      * This implementation executes the given {@link EventRunnable} within
      * the SWT UI thread.
      */
-    public void execute( EventRunnable<?> runnable )
+    public void execute( EventRunnable runnable )
     {
         Display.getDefault().asyncExec( runnable );
     }

Modified: directory/studio/trunk/ldapbrowser-core/src/main/java/org/apache/directory/studio/ldapbrowser/core/events/EventRegistry.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/ldapbrowser-core/src/main/java/org/apache/directory/studio/ldapbrowser/core/events/EventRegistry.java?rev=775047&r1=775046&r2=775047&view=diff
==============================================================================
--- directory/studio/trunk/ldapbrowser-core/src/main/java/org/apache/directory/studio/ldapbrowser/core/events/EventRegistry.java (original)
+++ directory/studio/trunk/ldapbrowser-core/src/main/java/org/apache/directory/studio/ldapbrowser/core/events/EventRegistry.java Fri May 15 07:33:57 2009
@@ -74,9 +74,9 @@
     {
         EventRunnableFactory<SearchUpdateListener> factory = new EventRunnableFactory<SearchUpdateListener>()
         {
-            public EventRunnable<SearchUpdateListener> createEventRunnable( final SearchUpdateListener listener )
+            public EventRunnable createEventRunnable( final SearchUpdateListener listener )
             {
-                return new EventRunnable<SearchUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -125,9 +125,9 @@
     {
         EventRunnableFactory<BookmarkUpdateListener> factory = new EventRunnableFactory<BookmarkUpdateListener>()
         {
-            public EventRunnable<BookmarkUpdateListener> createEventRunnable( final BookmarkUpdateListener listener )
+            public EventRunnable createEventRunnable( final BookmarkUpdateListener listener )
             {
-                return new EventRunnable<BookmarkUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -177,10 +177,9 @@
     {
         EventRunnableFactory<BrowserConnectionUpdateListener> factory = new EventRunnableFactory<BrowserConnectionUpdateListener>()
         {
-            public EventRunnable<BrowserConnectionUpdateListener> createEventRunnable(
-                final BrowserConnectionUpdateListener listener )
+            public EventRunnable createEventRunnable( final BrowserConnectionUpdateListener listener )
             {
-                return new EventRunnable<BrowserConnectionUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {
@@ -229,9 +228,9 @@
     {
         EventRunnableFactory<EntryUpdateListener> factory = new EventRunnableFactory<EntryUpdateListener>()
         {
-            public EventRunnable<EntryUpdateListener> createEventRunnable( final EntryUpdateListener listener )
+            public EventRunnable createEventRunnable( final EntryUpdateListener listener )
             {
-                return new EventRunnable<EntryUpdateListener>()
+                return new EventRunnable()
                 {
                     public void run()
                     {