You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2016/12/23 16:09:43 UTC
[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1803
[MINOR] fix: Initialize zeppelin var in visualization/builtin/*.js
### What is this PR for?
Fixed fragile code in src/app/visualization/bulitin This code causes loading errors as u can see the screenshot above. Especially in different loading system (e.g es6 import, require, webpack)
Let's initialize `zeppelin` var like other files do
- [visualization.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/visualization/visualization.js#L17)
- [tabledata.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/tabledata/tabledata.js#L17)
### What type of PR is it?
[Bug Fix]
### Todos
Nothing
### What is the Jira issue?
MINOR
### How should this be tested?
It's trivial.
### Screenshots (if appropriate)
<img width="1439" alt="screen shot 2016-12-24 at 12 34 35 am" src="https://cloud.githubusercontent.com/assets/4968473/21457826/602cf11e-c975-11e6-9974-bce5370a3833.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/fragile-code-visualization-js
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1803.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1803
----
commit 4549fdc88684cc0f76137d87144ae6bbef143735
Author: 1ambda <1a...@gmail.com>
Date: 2016-12-23T16:05:22Z
fix: Initialize zeppelin var
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1803
[MINOR] fix: Initialize zeppelin var in visualization/builtin/*.js
### What is this PR for?
Fixed fragile code in src/app/visualization/bulitin This code causes loading errors as u can see the screenshot above. Especially in different loading system (e.g es6 import, require, webpack)
Let's initialize `zeppelin` var like other files do
- [visualization.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/visualization/visualization.js#L17)
- [tabledata.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/tabledata/tabledata.js#L17)
### What type of PR is it?
[Bug Fix]
### Todos
Nothing
### What is the Jira issue?
MINOR
### How should this be tested?
It's trivial.
### Screenshots (if appropriate)
<img width="1439" alt="screen shot 2016-12-24 at 12 34 35 am" src="https://cloud.githubusercontent.com/assets/4968473/21457826/602cf11e-c975-11e6-9974-bce5370a3833.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/fragile-code-visualization-js
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1803.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1803
----
commit 4549fdc88684cc0f76137d87144ae6bbef143735
Author: 1ambda <1a...@gmail.com>
Date: 2016-12-23T16:05:22Z
fix: Initialize zeppelin var
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1803
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1803
[MINOR] fix: Initialize zeppelin var in visualization/builtin/*.js
### What is this PR for?
Fixed fragile code in src/app/visualization/bulitin This code causes loading errors as u can see the screenshot above. Especially in different loading system (e.g es6 import, require, webpack)
Let's initialize `zeppelin` var like other files do
- [visualization.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/visualization/visualization.js#L17)
- [tabledata.js#L17](https://github.com/apache/zeppelin/blob/6808bdc6966d6be5085003b47296bdc9917fd0a3/zeppelin-web/src/app/tabledata/tabledata.js#L17)
### What type of PR is it?
[Bug Fix]
### Todos
Nothing
### What is the Jira issue?
MINOR
### How should this be tested?
It's trivial.
### Screenshots (if appropriate)
<img width="1439" alt="screen shot 2016-12-24 at 12 34 35 am" src="https://cloud.githubusercontent.com/assets/4968473/21457826/602cf11e-c975-11e6-9974-bce5370a3833.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/fragile-code-visualization-js
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1803.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1803
----
commit 4549fdc88684cc0f76137d87144ae6bbef143735
Author: 1ambda <1a...@gmail.com>
Date: 2016-12-23T16:05:22Z
fix: Initialize zeppelin var
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1803: [MINOR] fix: Initialize zeppelin var in visualization/...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1803
LGTM and merge to master if there're no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1803
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1803
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---