You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "qwist1233-cpu (via GitHub)" <gi...@apache.org> on 2026/10/19 08:38:26 UTC

[PR] fix(settings): give provider model rows their own scroll viewport [maka]

qwist1233-cpu opened a new pull request, #6165:
URL: https://github.com/apache/maka/pull/6165

   ## Summary
   
   Opening a provider connection in Settings → 模型 renders every chat-capable model as a page row, so a fetched catalog of a few hundred models made the settings page itself hundreds of rows tall: the model filter scrolled out of view while browsing it, and the advanced request settings below sat under the whole list.
   
   The model rows now get their own scroll viewport. The filter, the model count and the section's buttons stay outside it, so they hold still while the rows scroll, and the sections below the list are a short scroll away instead of 400 rows away.
   
   Two deliberate choices:
   
   - `max-height: min(32rem, 60vh)`, not a fixed height. A small catalog, a filtered-down list and the empty-result row stand at their own height, with no blank box reserved under them, and in a short window the 60vh term keeps the surrounding section on screen.
   - The wrapper is a second `.settingsRows` rather than a plain `div`: the row styling in `rows.css` is written as `.settingsRows > …`, so the rows keep their edge-to-edge track, their hover wash and the 460px container query inside the viewport too.
   - `overscroll-behavior` is left at `auto` on purpose, so a wheel that reaches the end of the list carries on down the settings page instead of stopping dead.
   
   Fixes #6164
   
   ## Verification
   
   `apps/desktop` on Windows 11, Node 22.
   
   - **Storybook render smoke** — `npm run build-storybook` then the render smoke over the three provider stories below. The play functions are the test: they assert geometry in a real Chromium layout, and `scripts/storybook-visual-smoke.mjs` fails a render when a play function throws.
     - `Product/Settings/Providers/LargeConnectionDetail` (444-model fixture, 1280×900): the rows' viewport scrolls (`scrollHeight > clientHeight`), its height stays within `min(32rem, 60vh)` read from the live window, the settings pane's `scrollHeight` is now *smaller* than the list's — i.e. the page no longer carries the catalog — nothing overflows sideways, the filter and the 添加模型 button are not inside the viewport, and after scrolling to the end the last row's bottom edge lies inside the viewport rect. Filtering to `model-04` leaves 10 rows with `scrollHeight === clientHeight`, so a short list reserves no empty box.
     - `LargeConnectionDetailShortWindow` (new story, 480×800): the same assertions where `60vh` (480px) is the binding term rather than the `32rem` cap — the case the viewport-relative half of the bound exists for. `storyViewport()` in the smoke harness gives this story that size, with a unit test in `scripts/storybook-visual-smoke.test.mjs` covering both the size and why 900px tall would not exercise it.
     - `ConnectionDetailPage` (2-model catalog): the viewport is present but unscrolled and under the bound, and the filter stays absent below its 8-model threshold.
   - **Fails without the change** — reverting the two source files and rebuilding Storybook fails all three stories (`.providerModelRowsViewport` is absent, and the page-height assertion is the inverse of the old behaviour).
   - `node --test scripts/storybook-visual-smoke.test.mjs` — 17/17.
   - `npx biome check` on the changed files — clean.
   - `npm run typecheck:stories` — 33 pre-existing errors on `main` in unrelated files, 33 after this change, none in the touched files. Not fixed here.
   - Not run: the full `test` suite and packaging checks; nothing outside the renderer settings surface is touched.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Claude Code (Claude Opus 5) wrote the CSS rule, the JSX wrapper, the Storybook play-function assertions and the harness viewport case, under human direction and review; the commit carries a `Generated-by: Claude Code` trailer.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "qwist1233-cpu (via GitHub)" <gi...@apache.org>.
qwist1233-cpu commented on PR #6165:
URL: https://github.com/apache/maka/pull/6165#issuecomment-6286825525

   Here you go — both shots are the provider settings pane with a 444-model connection, dark scheme, 1280x900, captured headlessly with the repo's own tooling (`scripts/storybook-visual-diff.mjs capture`) from a temporary story that scrolls the pane to the same offset on both branches, so the two frames are comparable.
   
   **Before** (`main`) — the model list runs the full height of the pane; everything below it (Advanced request settings, headers, extra body) is pushed off and only reachable after scrolling through all 444 rows:
   
   ![before](https://raw.githubusercontent.com/qwist1233-cpu/maka/shots/6165/before.png)
   
   **After** (this PR) — the rows live in their own bounded viewport, so the rest of the connection settings stay on the same screen and the save bar is no longer pushed away by the list:
   
   ![after](https://raw.githubusercontent.com/qwist1233-cpu/maka/shots/6165/after.png)
   
   Also rebased on current `main`; the conflict was in `provider-settings.stories.tsx`, where your side had added the model-row assertions to `LargeConnectionDetail.play` — I kept both, so that play now checks the bounded viewport, the save-bar visibility at the top/middle/end of the pane, and the filtered-down case with no empty box under the rows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "qwist1233-cpu (via GitHub)" <gi...@apache.org>.
qwist1233-cpu commented on PR #6165:
URL: https://github.com/apache/maka/pull/6165#issuecomment-6336205890

   Architecture gate fixed in f593196, and it was the right call to flag it rather than let me widen the ledger.
   
   The clearance no longer lives in the detail view. `attachModelsSaveBarClearance` is a ref callback in `features/connection-settings`, re-exported from the feature's public entry, and the view just hands it to the bar: `ref={attachModelsSaveBarClearance}`. So the view's `hookCalls` and `environmentCapabilities` go back to exactly what main records — no `useLayoutEffect`, no `useRef`, no `ResizeObserver` — and the feature's public entry was already a sanctioned dependency for it, so `renderer-architecture.json` needed no edit at all.
   
   Verified at this head:
   
   - `npm --workspace @maka/desktop run check:architecture` passes, and so does `node scripts/check-renderer-architecture.mjs --base origin/main --strict-base` — the ratchet run that failed before. Its only output is the expected notice that the AppShell closure newly uses `attachModelsSaveBarClearance` from the feature entry (reported, not ratcheted).
   - Both fixes still hold in headless Chromium on `large-connection-detail-short-window`, 444-model fixture, dark scheme. At 600x320: focused parameter button bottom 137px against a bar top of 251px, `elementFromPoint` on its centre returns the button; published clearance `65px`; 18px of room to the right of the trailing Switch. At 1280x900: 413px against 831px, same hit result. Removing only the new CSS reproduces both faults in the same run — covered button (hit-test returns the bar) and 10px of room where the ring needs 3px plus offset.
   - `tsc -p tsconfig.renderer.json` and `tsc -p tsconfig.storybook.json` clean, Biome clean on the four changed files, and the six provider-settings play scenarios that touch the detail view pass (`large-connection-detail`, `large-connection-detail-short-window`, `connection-detail-page`, `model-parameter-save`, `retired-free-connection`, `model-capabilities`).
   
   One behavioural note: the bar only renders while the connection is live, so a retired connection publishes no custom property and the pane's `scroll-padding-block-end` falls back to `0px`. Other settings pages are untouched for the same reason.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on code in PR #6165:
URL: https://github.com/apache/maka/pull/6165#discussion_r4323079254


##########
apps/desktop/src/renderer/styles/settings/provider-editor.css:
##########
@@ -44,6 +44,27 @@
   color: var(--muted-foreground);
 }
 
+/* The model rows of a provider connection, in their own scroll viewport.
+ * Settings → 模型 → a connection expands every chat-capable model into the
+ * page, so a large catalog made the page itself hundreds of rows tall: the
+ * filter scrolled away while browsing, and the advanced request settings
+ * below sat under the whole list.
+ *
+ * `max-height`, not `height`: a small catalog, a filtered-down list and the
+ * empty-result row are as tall as their content, with no blank box reserved
+ * under them. The bound tracks the window — 60vh keeps the surrounding
+ * section visible in a short window, and the 32rem cap stops the list from
+ * eating a tall one.
+ *
+ * `overscroll-behavior` is deliberately left at `auto`: once the list is
+ * scrolled to its end the wheel carries on down the settings page, so the
+ * viewport cannot swallow the gesture of a user heading for the sections
+ * below it. */
+.providerModelRowsViewport {
+  max-height: min(32rem, 60vh);
+  overflow-y: auto;

Review Comment:
   [P2] Keep keyboard-focused model controls above the sticky Save bar in short windows
   
   At the supported 320px minimum window height, this nested scroll container can bring keyboard focus completely underneath `.providerModelsSaveBar`. Reproduced on the live `LargeConnectionDetailShortWindow` story: resize to 600x320, toggle a model to show the Save bar, focus model 443's Switch as setup, then press Tab to model 444's parameter button. The focused button is at y=288..316 while Save occupies y=251..316; elementFromPoint at the button center hits the Save bar. The list's y=138..330 is only partly visible, and inner scrolling does not compensate for the sticky overlay. Also reproduced at 600x480 and 800x320. Switching off this rule and the max-height (restoring the old page scroll behavior) makes the same Tab target visible at y=190..218, above Save.
   
   Please coordinate focus scrolling with the sticky bar/visible portion of the inner viewport, or ensure the entire list viewport fits in the unobscured pane. Add a short-height keyboard-focus assertion: current tests only check that Save is visible and that the last row lies inside the list's own rect, which both pass while the focused control is completely obscured. Screenshot retained locally at /tmp/6165-600x320-focus.png. Existing 480x800 case does not expose this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "me2seeks (via GitHub) via commits" <co...@maka.apache.org>.
me2seeks merged PR #6165:
URL: https://github.com/apache/maka/pull/6165


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "qwist1233-cpu (via GitHub)" <gi...@apache.org>.
qwist1233-cpu commented on PR #6165:
URL: https://github.com/apache/maka/pull/6165#issuecomment-6518744448

   Friendly ping - everything from the review is addressed and CI is green. Happy to rebase or split this up if that helps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on PR #6165:
URL: https://github.com/apache/maka/pull/6165#issuecomment-6263277456

   Screenshots before and after


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6165:
URL: https://github.com/apache/maka/pull/6165#discussion_r4335600915


##########
apps/desktop/src/renderer/settings/provider-connection-detail.tsx:
##########
@@ -154,6 +154,36 @@ type EditingRow =
   | 'add-model'
   | null;
 
+/** Publishes the sticky Save bar's height to the settings pane, which spends
+ *  it as `scroll-padding-block-end` (provider-editor.css).
+ *
+ *  The bar hangs over the bottom of the pane, and the model rows scroll in a
+ *  viewport of their own: tabbing from one row's control to the next scrolls
+ *  that viewport, and no amount of scrolling inside it can move a row out from
+ *  under a bar stuck to the pane. With the padding in place the pane itself
+ *  scrolls the focused control clear of the bar. Measured rather than tokenized
+ *  because the bar wraps at narrow widths, the same way the composer dock's
+ *  clearance is measured in `use-focused-preview.ts`. */
+function useSaveBarScrollClearance(enabled: boolean) {
+  const barRef = useRef<HTMLDivElement>(null);
+  useLayoutEffect(() => {

Review Comment:
   P2: this new lifecycle/resize hook makes the required renderer architecture check fail. CI run 39569088879 and the same strict check locally both report the newly added `ResizeObserver` capability and `useLayoutEffect`/`useRef` calls against this component's existing architecture record. Current main has none of these calls. Please place this work under an allowed owner and satisfy the architecture gate before merging; the browser focus fixes themselves pass the head/control checks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on code in PR #6165:
URL: https://github.com/apache/maka/pull/6165#discussion_r4312240300


##########
apps/desktop/src/renderer/styles/settings/provider-editor.css:
##########
@@ -44,6 +44,27 @@
   color: var(--muted-foreground);
 }
 
+/* The model rows of a provider connection, in their own scroll viewport.
+ * Settings → 模型 → a connection expands every chat-capable model into the
+ * page, so a large catalog made the page itself hundreds of rows tall: the
+ * filter scrolled away while browsing, and the advanced request settings
+ * below sat under the whole list.
+ *
+ * `max-height`, not `height`: a small catalog, a filtered-down list and the
+ * empty-result row are as tall as their content, with no blank box reserved
+ * under them. The bound tracks the window — 60vh keeps the surrounding
+ * section visible in a short window, and the 32rem cap stops the list from
+ * eating a tall one.
+ *
+ * `overscroll-behavior` is deliberately left at `auto`: once the list is
+ * scrolled to its end the wheel carries on down the settings page, so the
+ * viewport cannot swallow the gesture of a user heading for the sections
+ * below it. */
+.providerModelRowsViewport {
+  max-height: min(32rem, 60vh);
+  overflow-y: auto;

Review Comment:
   P2: `overflow-y: auto` also makes `overflow-x` clip, and the rows are edge-to-edge, so the trailing Switch's `:focus-visible` ring (about 3px outside the element) gets cut off on the right edge. I measured and screenshotted this in both the 1280 and the 480 story. rows.css documents exactly this as a keyboard-visibility regression to avoid. A small inset that you take back keeps the ring visible and the track aligned, e.g. `padding: var(--space-1); margin-inline: calc(-1 * var(--space-1));`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "qwist1233-cpu (via GitHub)" <gi...@apache.org>.
qwist1233-cpu commented on PR #6165:
URL: https://github.com/apache/maka/pull/6165#issuecomment-6311507911

   Both points addressed in edc83c7.
   
   **Focus ring.** The viewport now steps out by `--space-2` and takes the same amount straight back as padding, so the ring has room inside the clip without moving the rows. Measured in headless Chromium on `large-connection-detail-short-window`: 18px of space to the right of the trailing Switch, where before the fix it was 0.0px — the ring needs 4px (`--focus-ring-width` 2 + `--focus-ring-offset` 2).
   
   **Save bar.** You were right that the row-bottom assertion says nothing about focus paint. The bar is sticky over the pane, so scrolling inside the viewport can never move a row out from under it; the pane now reserves the bar's measured height as `scroll-padding-block-end` and scrolls itself instead. The height is published by a ResizeObserver, the same way `use-focused-preview.ts` publishes `--maka-focused-composer-space`; it resolves to 65px here, and the property defaults to `0px` so the other settings pages are untouched.
   
   To be sure this was real and not just a plausible story, I walked 11 pane scroll positions at 600x320, 480x800 and 1280x900 and focused the last Switch at each one. Without the fix there is exactly one position per size where the focused control is covered and `document.elementFromPoint` on its centre returns the Save bar; with the fix there is none.
   
   **Coverage.** The play function now does that same walk and asserts the focused control is clear of the bar by geometry and by hit test. It fails without the fix at 480x800, 600x480, 600x320 and 1280x900 ("expected false to be true") and passes with it. `large-connection-detail`, `large-connection-detail-short-window` and `connection-detail-page` still pass at their own viewports; typecheck and `biome lint` are clean on the three files.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "qwist1233-cpu (via GitHub)" <gi...@apache.org>.
qwist1233-cpu commented on code in PR #6165:
URL: https://github.com/apache/maka/pull/6165#discussion_r4375215283


##########
apps/desktop/src/renderer/styles/settings/provider-editor.css:
##########
@@ -44,6 +44,27 @@
   color: var(--muted-foreground);
 }
 
+/* The model rows of a provider connection, in their own scroll viewport.
+ * Settings → 模型 → a connection expands every chat-capable model into the
+ * page, so a large catalog made the page itself hundreds of rows tall: the
+ * filter scrolled away while browsing, and the advanced request settings
+ * below sat under the whole list.
+ *
+ * `max-height`, not `height`: a small catalog, a filtered-down list and the
+ * empty-result row are as tall as their content, with no blank box reserved
+ * under them. The bound tracks the window — 60vh keeps the surrounding
+ * section visible in a short window, and the 32rem cap stops the list from
+ * eating a tall one.
+ *
+ * `overscroll-behavior` is deliberately left at `auto`: once the list is
+ * scrolled to its end the wheel carries on down the settings page, so the
+ * viewport cannot swallow the gesture of a user heading for the sections
+ * below it. */
+.providerModelRowsViewport {
+  max-height: min(32rem, 60vh);
+  overflow-y: auto;

Review Comment:
   Addressed, and your window is now in the gate.
   
   **The fix** (edc83c7, moved to its own module in f593196): the pane publishes the Save bar's measured height as `scroll-padding-block-end`, so focus moving into the list scrolls the *pane*, not only the inner viewport. Scrolling inside the viewport could never move a row out from under a bar stuck to the pane — that was the hole you found.
   
   **The assertion you asked for** is in `expectLastRowControlFullyVisible`, and 80ae254 runs it in the shortest supported window as well: the story now has two smoke jobs, `480x800` and `600x320`. It walks the pane through 11 scroll positions, refocuses the trailing control at each, and checks both the rect overlap and `elementFromPoint` at the control's centre.
   
   **Measured on 80ae254**, headless Chromium, story `large-connection-detail-short-window` at 600x320, focusing model 444's parameter button (`配置模型参数`) after the viewport is scrolled to its end:
   
   ```
   pane     scrollHeight 1247  clientHeight 312   scrollTop after focus 631
   list     y = -35..157       scrollHeight 19552 clientHeight 192  (60vh wins)
   Save bar y = 251..316       sticky
   button   y = 113..141       elementFromPoint at its centre: the button, not the bar
   ```
   
   The check is not vacuous. With `scroll-padding-block-end` forced to `0px` and nothing else changed, the same story fails on that assertion at **both** 600x320 and 480x800:
   
   ```
   FAIL 480x800: AssertionError: expected false to be true
   FAIL 600x320: AssertionError: expected false to be true
   ```
   
   and passes at both with the rule in place. So 480x800 does expose it once the assertion exists — what it could not expose was the old row-bottom geometry check, which is the gap you named. I kept 600x320 anyway: it is the shortest window the shell supports and the one you reproduced in, so the regression test now lives where the bug did.
   
   `node --test scripts/storybook-visual-smoke.test.mjs` passes (17 tests), with the job matrix for the story asserted rather than left implicit.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): give provider model rows their own scroll viewport [maka]

Posted by "qwist1233-cpu (via GitHub) via commits" <co...@maka.apache.org>.
qwist1233-cpu commented on PR #6165:
URL: https://github.com/apache/maka/pull/6165#issuecomment-6790519198

   Gentle ping — approved on Oct 30 and still green/conflict-free against main. Is there anything else you need from my side before this can be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org