You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2017/04/28 10:23:15 UTC
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated April 28, 2017, 10:23 a.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs
-----
lens-api/src/main/resources/cube-0.1.xsd 68ccc13
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
Diff: https://reviews.apache.org/r/58796/diff/2/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review173578
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
Lines 1280 (patched)
<https://reviews.apache.org/r/58796/#comment246572>
Instead of doing creation of the fact here, can we do getVirtualFactTable(vFactName) and validate?
- Amareshwari Sriramadasu
On April 28, 2017, 10:23 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 10:23 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 68ccc13
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/2/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
> On May 2, 2017, 6:51 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
> > Lines 1268 (patched)
> > <https://reviews.apache.org/r/58796/diff/2/?file=1701403#file1701403line1268>
> >
> > Can we create virtual fact belonging to a different cube than source fact?
As discussed, this should work
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review173559
-----------------------------------------------------------
On May 8, 2017, 6:08 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 6:08 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 68ccc13
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java e00122d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 599027f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6d61f1f
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java b9ff0ef
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c63c4c0
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 310a655
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 95e3c95
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 10c3bbe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 033264c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java bab1080
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/3/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review173559
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 386 (patched)
<https://reviews.apache.org/r/58796/#comment246550>
Why are all source fact properties getting copied for virtual fact? I feel, we shouldn't be doing this.
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 27 (patched)
<https://reviews.apache.org/r/58796/#comment246552>
Can we avoid extends of the CubeFactTable, as the class is already composing sourceFactTable ?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 32 (patched)
<https://reviews.apache.org/r/58796/#comment246554>
Not sure how are we passing sourceHiveTable for the constructor here?
We need to actually store the source fact table as a property name underlying Hive table.
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
Lines 1268 (patched)
<https://reviews.apache.org/r/58796/#comment246555>
Can we create virtual fact belonging to a different cube than source fact?
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
Lines 432 (patched)
<https://reviews.apache.org/r/58796/#comment246556>
Can we name the param vFact ? Applies to all methods.
- Amareshwari Sriramadasu
On April 28, 2017, 10:23 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 10:23 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 68ccc13
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/2/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
> On May 9, 2017, 9:39 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
> > Lines 84 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709967#file1709967line84>
> >
> > We need to persist sourceFactName as well.
done
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review174282
-----------------------------------------------------------
On May 15, 2017, 1:38 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 1:38 p.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/4/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review174282
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 84 (patched)
<https://reviews.apache.org/r/58796/#comment247410>
We need to persist sourceFactName as well.
- Amareshwari Sriramadasu
On May 8, 2017, 6:08 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 6:08 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 68ccc13
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java e00122d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 599027f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6d61f1f
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java b9ff0ef
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c63c4c0
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 310a655
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 95e3c95
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 10c3bbe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 033264c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java bab1080
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/3/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java
> > Lines 229-234 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709963#file1709963line229>
> >
> > Can we move this method to MetastoreUtil or even remove it and use the onliner 'props.get(MetastoreUtil.getFactCubeNameKey(factName));' from the caller itself?
done.
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
> > Lines 98 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709965#file1709965line108>
> >
> > Why is this mapping required?
removed this
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
> > Line 136 (original), 134 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709965#file1709965line144>
> >
> > Does extractStorageName has to work on FactTable interface as well?
As discussed, yes.
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
> > Line 2195 (original), 2326 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709965#file1709965line2336>
> >
> > Shall we return all facts here both direct facts and virtual facts?
> >
> > We can have one more method which takes a boolean to include virtual facts or not?
done
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
> > Lines 29 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709968#file1709968line29>
> >
> > remvoe author tags.
done
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
> > Lines 31 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709968#file1709968line31>
> >
> > Can we add javadoc for all the methods in interface?
done
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709968#file1709968line55>
> >
> > This looks more a util method and shouldnt sit in interface.
done
> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java
> > Lines 725 (patched)
> > <https://reviews.apache.org/r/58796/diff/3/?file=1709969#file1709969line725>
> >
> > Why are we doing this copy of properties?
removed
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review174275
-----------------------------------------------------------
On May 15, 2017, 1:38 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 1:38 p.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/4/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review174275
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java
Lines 229-234 (patched)
<https://reviews.apache.org/r/58796/#comment247400>
Can we move this method to MetastoreUtil or even remove it and use the onliner 'props.get(MetastoreUtil.getFactCubeNameKey(factName));' from the caller itself?
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java
Lines 233 (patched)
<https://reviews.apache.org/r/58796/#comment247401>
Same as above. Also seems method name is misleading.
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 98 (patched)
<https://reviews.apache.org/r/58796/#comment247402>
Why is this mapping required?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Line 136 (original), 134 (patched)
<https://reviews.apache.org/r/58796/#comment247403>
Does extractStorageName has to work on FactTable interface as well?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Line 2195 (original), 2326 (patched)
<https://reviews.apache.org/r/58796/#comment247404>
Shall we return all facts here both direct facts and virtual facts?
We can have one more method which takes a boolean to include virtual facts or not?
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
Lines 29 (patched)
<https://reviews.apache.org/r/58796/#comment247405>
remvoe author tags.
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
Lines 31 (patched)
<https://reviews.apache.org/r/58796/#comment247407>
Can we add javadoc for all the methods in interface?
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
Lines 55 (patched)
<https://reviews.apache.org/r/58796/#comment247406>
This looks more a util method and shouldnt sit in interface.
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java
Lines 725 (patched)
<https://reviews.apache.org/r/58796/#comment247408>
Why are we doing this copy of properties?
- Amareshwari Sriramadasu
On May 8, 2017, 6:08 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 6:08 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 68ccc13
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java e00122d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 599027f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6d61f1f
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java b9ff0ef
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c63c4c0
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 310a655
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 95e3c95
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 10c3bbe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 033264c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java bab1080
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/3/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175246
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 597 (original), 596 (patched)
<https://reviews.apache.org/r/58796/#comment248699>
I'm not sure if handling can be skipped for virtual fact.
- Amareshwari Sriramadasu
On May 17, 2017, 11:54 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:54 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/7/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review176761
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 2, 2017, 9:41 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 9:41 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
> lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
> lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
> lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-driver-es/pom.xml 925020e
> lens-examples/pom.xml af467ee
> lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
> lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
> lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
> lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
> lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
> lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
> lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/pom.xml 60ed1ae
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
> src/site/apt/user/cli.apt fce41fe
> tools/scripts/generate-site-public.sh 109268c
>
>
> Diff: https://reviews.apache.org/r/58796/diff/18/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review176897
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 430 (original), 420 (patched)
<https://reviews.apache.org/r/58796/#comment250440>
Seems still some more unrelated changes here.
- Amareshwari Sriramadasu
On June 2, 2017, 7:04 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 7:04 p.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
> lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
> lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
> lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-driver-es/pom.xml 925020e
> lens-examples/pom.xml af467ee
> lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
> lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
> lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
> lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
> lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
> lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
> lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/pom.xml 60ed1ae
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java df4e07a
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
> src/site/apt/user/cli.apt fce41fe
> tools/scripts/generate-site-public.sh 109268c
>
>
> Diff: https://reviews.apache.org/r/58796/diff/19/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated June 2, 2017, 7:04 p.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-api/src/main/resources/lens-errors.conf 43de1e9
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-driver-es/pom.xml 925020e
lens-examples/pom.xml af467ee
lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/pom.xml 60ed1ae
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java df4e07a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
src/site/apt/user/cli.apt fce41fe
tools/scripts/generate-site-public.sh 109268c
Diff: https://reviews.apache.org/r/58796/diff/19/
Changes: https://reviews.apache.org/r/58796/diff/18-19/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review176749
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java
Lines 359 (patched)
<https://reviews.apache.org/r/58796/#comment250219>
Why are these changes required? Seems there are many unrelated code changes like this included in this review request. Might have to revert.
- Amareshwari Sriramadasu
On June 2, 2017, 9:41 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 9:41 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> checkstyle/pom.xml 2902c6b
> contrib/clients/python/pom.xml ac842bd
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
> lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
> lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
> lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-dist/src/deb/control/postinst PRE-CREATION
> lens-driver-es/pom.xml 925020e
> lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml ac5e43d
> lens-examples/pom.xml af467ee
> lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
> lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
> lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
> lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
> lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
> lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
> lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java 2667ebf
> lens-server/pom.xml 60ed1ae
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
> pom.xml af7dafa
> src/site/apt/user/cli.apt fce41fe
> tools/scripts/generate-site-public.sh 109268c
>
>
> Diff: https://reviews.apache.org/r/58796/diff/14/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated June 2, 2017, 9:41 a.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Changes
-------
Removing unwanted files
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
checkstyle/pom.xml 2902c6b
contrib/clients/python/pom.xml ac842bd
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-api/src/main/resources/lens-errors.conf 43de1e9
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-dist/src/deb/control/postinst PRE-CREATION
lens-driver-es/pom.xml 925020e
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 75153f6
lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml ac5e43d
lens-examples/pom.xml af467ee
lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java 2667ebf
lens-server/pom.xml 60ed1ae
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
pom.xml af7dafa
src/site/apt/user/cli.apt fce41fe
tools/scripts/generate-site-public.sh 109268c
Diff: https://reviews.apache.org/r/58796/diff/12/
Changes: https://reviews.apache.org/r/58796/diff/11-12/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated June 2, 2017, 7:20 a.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Changes
-------
Test case for virtual fact in cli
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
checkstyle/pom.xml 2902c6b
contrib/clients/pom.xml d7677a3
contrib/clients/python/pom.xml ac842bd
contrib/pom.xml b36add0
lens-api/pom.xml ece4430
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-api/src/main/resources/lens-errors.conf 43de1e9
lens-cli/pom.xml 3640fdd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
lens-client/pom.xml 5b94800
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
lens-cube/pom.xml deaeb36
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-dist/pom.xml fb49931
lens-dist/src/deb/control/postinst PRE-CREATION
lens-driver-es/pom.xml 925020e
lens-driver-hive/pom.xml 51205e9
lens-driver-jdbc/pom.xml 5acd5d2
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 75153f6
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 8e042d1
lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml ac5e43d
lens-examples/pom.xml af467ee
lens-examples/src/main/resources/cube11.xml PRE-CREATION
lens-examples/src/main/resources/cube22.xml PRE-CREATION
lens-examples/src/main/resources/cube33.xml PRE-CREATION
lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
lens-ml-dist/pom.xml c75e2ab
lens-ml-lib/pom.xml 959efe8
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java ce3db42
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java ff47353
lens-query-lib/pom.xml c21e77f
lens-regression/pom.xml a4f857d
lens-server-api/pom.xml 93f79ff
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java 2667ebf
lens-server/pom.xml 60ed1ae
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 9a1d79d
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java df4e07a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
lens-ship-jars/pom.xml 67867a4
lens-storage-db/pom.xml 68c6e46
lens-ui/pom.xml 1185be9
pom.xml af7dafa
src/site/apt/user/cli.apt fce41fe
tools/scripts/generate-site-public.sh 109268c
Diff: https://reviews.apache.org/r/58796/diff/11/
Changes: https://reviews.apache.org/r/58796/diff/10-11/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
> On May 25, 2017, 9:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/cube-0.1.xsd
> > Lines 1226 (patched)
> > <https://reviews.apache.org/r/58796/diff/10/?file=1727017#file1727017line1296>
> >
> > should we say columns and storages
will do
> On May 25, 2017, 9:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/cube-0.1.xsd
> > Lines 1256 (patched)
> > <https://reviews.apache.org/r/58796/diff/10/?file=1727017#file1727017line1326>
> >
> > Shall we move properties to x_fact ?
Can't move it as existing schema order will have to change
> On May 25, 2017, 9:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/cube-0.1.xsd
> > Lines 1290 (patched)
> > <https://reviews.apache.org/r/58796/diff/10/?file=1727017#file1727017line1360>
> >
> > Should we move weight to x_fact ?
Weight is optional in virtual and mandatory in base..so din't move it to x fact
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review176051
-----------------------------------------------------------
On June 2, 2017, 9:41 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 9:41 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> checkstyle/pom.xml 2902c6b
> contrib/clients/python/pom.xml ac842bd
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
> lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
> lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
> lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-dist/src/deb/control/postinst PRE-CREATION
> lens-driver-es/pom.xml 925020e
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 75153f6
> lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml ac5e43d
> lens-examples/pom.xml af467ee
> lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
> lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
> lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
> lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
> lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
> lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
> lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java 2667ebf
> lens-server/pom.xml 60ed1ae
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
> pom.xml af7dafa
> src/site/apt/user/cli.apt fce41fe
> tools/scripts/generate-site-public.sh 109268c
>
>
> Diff: https://reviews.apache.org/r/58796/diff/12/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review176051
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd
Lines 1226 (patched)
<https://reviews.apache.org/r/58796/#comment249382>
should we say columns and storages
lens-api/src/main/resources/cube-0.1.xsd
Lines 1256 (patched)
<https://reviews.apache.org/r/58796/#comment249384>
Shall we move properties to x_fact ?
lens-api/src/main/resources/cube-0.1.xsd
Lines 1290 (patched)
<https://reviews.apache.org/r/58796/#comment249383>
Should we move weight to x_fact ?
- Amareshwari Sriramadasu
On May 22, 2017, 10:59 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 10:59 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
> lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
> lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
> lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
> lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
> lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
> lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 9a1d79d
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java df4e07a
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
> src/site/apt/user/cli.apt fce41fe
>
>
> Diff: https://reviews.apache.org/r/58796/diff/10/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review176055
-----------------------------------------------------------
Can we include unit test on client side as well?
- Amareshwari Sriramadasu
On May 22, 2017, 10:59 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 10:59 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
> lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
> lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
> lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
> lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
> lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
> lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 9a1d79d
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java df4e07a
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
> src/site/apt/user/cli.apt fce41fe
>
>
> Diff: https://reviews.apache.org/r/58796/diff/10/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated May 22, 2017, 10:59 a.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Changes
-------
Changes post review comments
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-api/src/main/resources/lens-errors.conf 43de1e9
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/common/FormDataMultiPartFactory.java 9a1d79d
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java df4e07a
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
src/site/apt/user/cli.apt fce41fe
Diff: https://reviews.apache.org/r/58796/diff/9/
Changes: https://reviews.apache.org/r/58796/diff/8-9/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175244
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Line 2459 (original), 2600 (patched)
<https://reviews.apache.org/r/58796/#comment248698>
need to call getCubeFactTable() ?
- Amareshwari Sriramadasu
On May 17, 2017, 11:54 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:54 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/7/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated May 17, 2017, 11:54 a.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Changes
-------
Changes post review
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-api/src/main/resources/lens-errors.conf 43de1e9
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
Diff: https://reviews.apache.org/r/58796/diff/7/
Changes: https://reviews.apache.org/r/58796/diff/6-7/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
> > Lines 95 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720857#file1720857line105>
> >
> > Why would we need this mapping? Can you add a comment on why this mapping is required?
done
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
> > Lines 2550 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720857#file1720857line2574>
> >
> > It is dropping tables not just from cache, but persisted tables as well, might need rename.
done
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
> > Line 2459 (original), 2599 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720857#file1720857line2623>
> >
> > Can we make sure all callers for the methods where getCubeFact() is getting casted to (CubeFactTable), virtual fact table will never be passed?
Done.
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java
> > Lines 416 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720862#file1720862line416>
> >
> > can we put back the error?
done
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Line 607 (original), 597 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720867#file1720867line611>
> >
> > Seems getFact() can be virtual fact as well. Casting would result in error
Fixed
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
> > Lines 1264 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720871#file1720871line1264>
> >
> > Can we make virtual fact table to belong to a different cube?
done
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
> > Lines 469 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720876#file1720876line469>
> >
> > remove commented code
done
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
> > Lines 490 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720877#file1720877line490>
> >
> > remove commented code
done
> On May 17, 2017, 7:18 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
> > Lines 186 (patched)
> > <https://reviews.apache.org/r/58796/diff/6/?file=1720878#file1720878line186>
> >
> > returning all facts? Instead should we say not implemented
done
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175209
-----------------------------------------------------------
On May 17, 2017, 11:54 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:54 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/7/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175209
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 95 (patched)
<https://reviews.apache.org/r/58796/#comment248618>
Why would we need this mapping? Can you add a comment on why this mapping is required?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Line 194 (original), 188 (patched)
<https://reviews.apache.org/r/58796/#comment248617>
Should caller make sure not pass virtualFact name for this method? Or even we can do a check here and throw proper error.
If not check done from call and here, it can result 500 errors on api.
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 2550 (patched)
<https://reviews.apache.org/r/58796/#comment248619>
It is dropping tables not just from cache, but persisted tables as well, might need rename.
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Line 2459 (original), 2599 (patched)
<https://reviews.apache.org/r/58796/#comment248620>
Can we make sure all callers for the methods where getCubeFact() is getting casted to (CubeFactTable), virtual fact table will never be passed?
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java
Lines 416 (patched)
<https://reviews.apache.org/r/58796/#comment248623>
can we put back the error?
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 607 (original), 597 (patched)
<https://reviews.apache.org/r/58796/#comment248624>
Seems getFact() can be virtual fact as well. Casting would result in error
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
Lines 1264 (patched)
<https://reviews.apache.org/r/58796/#comment248625>
Can we make virtual fact table to belong to a different cube?
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
Lines 469 (patched)
<https://reviews.apache.org/r/58796/#comment248626>
remove commented code
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
Lines 490 (patched)
<https://reviews.apache.org/r/58796/#comment248627>
remove commented code
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
Lines 186 (patched)
<https://reviews.apache.org/r/58796/#comment248628>
returning all facts? Instead should we say not implemented
- Amareshwari Sriramadasu
On May 16, 2017, 12:21 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 12:21 p.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/6/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated May 16, 2017, 12:21 p.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Changes
-------
Review changes
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
Diff: https://reviews.apache.org/r/58796/diff/6/
Changes: https://reviews.apache.org/r/58796/diff/5-6/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated May 16, 2017, 11:35 a.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
Diff: https://reviews.apache.org/r/58796/diff/5/
Changes: https://reviews.apache.org/r/58796/diff/4-5/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD and Query rewrite changes for Virtual
Fact and Unit test cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
> On May 16, 2017, 2:57 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Line 607 (original), 602 (patched)
> > <https://reviews.apache.org/r/58796/diff/4/?file=1718297#file1718297line616>
> >
> > Should we create an interface for AbstractCubeTable say CubeTable and FactTabe interface should extend CubeTable interface ? This will prevent all typecasting to CubeFactTable. [Optional]
Dropping this feature for now
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175056
-----------------------------------------------------------
On June 2, 2017, 9:41 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 9:41 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> checkstyle/pom.xml 2902c6b
> contrib/clients/python/pom.xml ac842bd
> lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 9564443
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-api/src/main/resources/lens-errors.conf 43de1e9
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java a01d6c0
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 20f313a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java d31e25c
> lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java ca6db2c
> lens-cli/src/test/resources/schema/cubes/base/virtual-cube.xml PRE-CREATION
> lens-cli/src/test/resources/schema/facts/virtual_fact.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 4f8da06
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java f077c9c
> lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 32b9db3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 47bce65
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 6c0d91a
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java fe52600
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 7ec3324
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-dist/src/deb/control/postinst PRE-CREATION
> lens-driver-es/pom.xml 925020e
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 75153f6
> lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml ac5e43d
> lens-examples/pom.xml af467ee
> lens-examples/src/test/resources/yaml/fact1.yaml 9c1c527
> lens-examples/src/test/resources/yaml/fact2.yaml 6fadd11
> lens-examples/src/test/resources/yaml/rawfact.yaml f7b2d55
> lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml f95f91b
> lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml 02f65ff
> lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml ff47d36
> lens-examples/src/test/resources/yaml/sales-raw-fact.yaml 15becfc
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java 2667ebf
> lens-server/pom.xml 60ed1ae
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
> pom.xml af7dafa
> src/site/apt/user/cli.apt fce41fe
> tools/scripts/generate-site-public.sh 109268c
>
>
> Diff: https://reviews.apache.org/r/58796/diff/13/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
> On May 16, 2017, 2:57 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/58796/diff/4/?file=1718288#file1718288line46>
> >
> > Second param type can be FactTable
done
> On May 16, 2017, 2:57 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/58796/diff/4/?file=1718288#file1718288line51>
> >
> > This is redundant.
removed
> On May 16, 2017, 2:57 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
> > Lines 167 (patched)
> > <https://reviews.apache.org/r/58796/diff/4/?file=1718288#file1718288line167>
> >
> > Should we call this getSourceFactName()?
> > In case of CFT it will return getName(). In case of VFT it will return sourceCubeFactTable.getName()
done
> On May 16, 2017, 2:57 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Lines 200 (patched)
> > <https://reviews.apache.org/r/58796/diff/4/?file=1718297#file1718297line209>
> >
> > This method should not be needed since FactTable interface has a similar method.
removed
> On May 16, 2017, 2:57 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
> > Lines 136-152 (patched)
> > <https://reviews.apache.org/r/58796/diff/4/?file=1718298#file1718298line136>
> >
> > should we optimize this and reduce if checks ?
done
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175056
-----------------------------------------------------------
On May 16, 2017, 11:35 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 16, 2017, 11:35 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/5/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175056
-----------------------------------------------------------
partial review
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 46 (patched)
<https://reviews.apache.org/r/58796/#comment248397>
Second param type can be FactTable
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 51 (patched)
<https://reviews.apache.org/r/58796/#comment248398>
This is redundant.
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 94 (patched)
<https://reviews.apache.org/r/58796/#comment248395>
Can this also return a Set ? It will be faster to do contains opeartion on a set.
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 133 (patched)
<https://reviews.apache.org/r/58796/#comment248399>
What happens if
1. VFT start time is < FT start time ?
2. VFT has no start time defined but FT has start time defined ?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 167 (patched)
<https://reviews.apache.org/r/58796/#comment248400>
Should we call this getSourceFactName()?
In case of CFT it will return getName(). In case of VFT it will return sourceCubeFactTable.getName()
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
Lines 73 (patched)
<https://reviews.apache.org/r/58796/#comment248396>
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Lines 200 (patched)
<https://reviews.apache.org/r/58796/#comment248401>
This method should not be needed since FactTable interface has a similar method.
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 607 (original), 602 (patched)
<https://reviews.apache.org/r/58796/#comment248402>
Should we create an interface for AbstractCubeTable say CubeTable and FactTabe interface should extend CubeTable interface ? This will prevent all typecasting to CubeFactTable. [Optional]
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
Lines 136-152 (patched)
<https://reviews.apache.org/r/58796/#comment248403>
should we optimize this and reduce if checks ?
- Puneet Gupta
On May 15, 2017, 1:38 p.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 1:38 p.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 8158e6d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/4/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated May 15, 2017, 1:38 p.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Changes
-------
Changes post comments
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 8158e6d
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 88bc1fc
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 40f766b
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java a8d6fbd
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 6ba46d6
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 43510dd
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 1e54f13
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 730b802
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 291712b
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 42e32cb
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java a76ef13
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 2f300d3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 7d1f80d
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
Diff: https://reviews.apache.org/r/58796/diff/4/
Changes: https://reviews.apache.org/r/58796/diff/3-4/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review173575
-----------------------------------------------------------
Partial Review.
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 382 (patched)
<https://reviews.apache.org/r/58796/#comment246568>
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 386 (patched)
<https://reviews.apache.org/r/58796/#comment246571>
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java
Lines 229-235 (patched)
<https://reviews.apache.org/r/58796/#comment247266>
Can we move these methods else where (may be deafult methods in FactTable interface) as they are specific to tables that have a cube and not common to all the tables (example Dimensions, Storage).
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 94 (patched)
<https://reviews.apache.org/r/58796/#comment247268>
Should we call it factToVirtualFactsMapping ?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 98 (patched)
<https://reviews.apache.org/r/58796/#comment247269>
Should we call this virtualFactToFactMapping ?
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
Lines 29 (patched)
<https://reviews.apache.org/r/58796/#comment247265>
author name needs to be removed .
- Puneet Gupta
On May 8, 2017, 6:08 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 6:08 a.m.)
>
>
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> CRUD changes and Unit test cases for Virtual Fact
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 68ccc13
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java e00122d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 599027f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6d61f1f
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java b9ff0ef
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c63c4c0
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 310a655
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 95e3c95
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 10c3bbe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 033264c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java bab1080
> lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
> lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
>
>
> Diff: https://reviews.apache.org/r/58796/diff/3/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
> [INFO] Lens .............................................. SUCCESS [3.449s]
> [INFO] Lens API .......................................... SUCCESS [23.572s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
> [INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
> [INFO] Lens DB storage ................................... SUCCESS [17.013s]
> [INFO] Lens Query Library ................................ SUCCESS [13.632s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
> [INFO] Lens Server ....................................... SUCCESS [16:38.220s]
> [INFO] Lens client ....................................... SUCCESS [1:25.658s]
> [INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
> [INFO] Lens Examples ..................................... SUCCESS [8.432s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
> [INFO] Lens Distribution ................................. SUCCESS [9.499s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
> [INFO] Lens Regression ................................... SUCCESS [12.136s]
> [INFO] Lens UI ........................................... SUCCESS [32.999s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.358s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
> [INFO] Lens Python Client ................................ SUCCESS [0.366s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajitha R
>
>
Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test
cases [Lens-1412]
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/
-----------------------------------------------------------
(Updated May 8, 2017, 6:08 a.m.)
Review request for lens, Rajat Khandelwal and Puneet Gupta.
Changes
-------
More changes for Virtual Fact post review
Repository: lens
Description
-------
CRUD changes and Unit test cases for Virtual Fact
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 68ccc13
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 67aaff8
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java e00122d
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java b5c4c89
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 6dd35b3
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java e1e3d16
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 88500fd
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 599027f
lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 1e3cef3
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 6d61f1f
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java b9ff0ef
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c63c4c0
lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 310a655
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 95e3c95
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 10c3bbe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 3a17499
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 033264c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java bab1080
lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION
lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java 28b9d22
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 194b380
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 7451aa9
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6d32d23
Diff: https://reviews.apache.org/r/58796/diff/3/
Changes: https://reviews.apache.org/r/58796/diff/2-3/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s]
[INFO] Lens .............................................. SUCCESS [3.449s]
[INFO] Lens API .......................................... SUCCESS [23.572s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.051s]
[INFO] Lens Cube ......................................... SUCCESS [5:41.995s]
[INFO] Lens DB storage ................................... SUCCESS [17.013s]
[INFO] Lens Query Library ................................ SUCCESS [13.632s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s]
[INFO] Lens Server ....................................... SUCCESS [16:38.220s]
[INFO] Lens client ....................................... SUCCESS [1:25.658s]
[INFO] Lens CLI .......................................... SUCCESS [1:16.332s]
[INFO] Lens Examples ..................................... SUCCESS [8.432s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s]
[INFO] Lens Distribution ................................. SUCCESS [9.499s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s]
[INFO] Lens Regression ................................... SUCCESS [12.136s]
[INFO] Lens UI ........................................... SUCCESS [32.999s]
[INFO] Lens Contrib ...................................... SUCCESS [0.358s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.360s]
[INFO] Lens Python Client ................................ SUCCESS [0.366s]
[INFO] ------------------------------------------------------------------------
Thanks,
Rajitha R