[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence

["Udi Meiri (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993127#comment-16993127 ] 

Udi Meiri commented on BEAM-8572:
---------------------------------

We discussed this a while back on the mailing list, and the consensus IIRC was that Cython was being correctly installed, except that these tests weren't detecting it correctly.
I've tracked it down to how utils.check_compiled() is used. It was pointed to a module that doesn't get cythonized (is always from a .py or .pyc file).
https://github.com/apache/beam/pull/7606/files

> tox environment: assert on Cython source file presence
> ------------------------------------------------------
>
>                 Key: BEAM-8572
>                 URL: https://issues.apache.org/jira/browse/BEAM-8572
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core, testing
>            Reporter: Udi Meiri
>            Assignee: Udi Meiri
>            Priority: Major
>
> Add an assertion somewhere that checks if Cythonized files are present in the sdist tarball in use. That is for "tox -e py27" assert that these files are not present, for "tox -e py27-cython" assert that they are present.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)