[GitHub] [parquet-mr] zhaochengzhch commented on a diff in pull request #507: PARQUET-1364: Invalid row indexes for pages starting with nulls

["zhaochengzhch (via GitHub)" <gi...@apache.org>]

zhaochengzhch commented on code in PR #507:
URL: https://github.com/apache/parquet-mr/pull/507#discussion_r1295348134


##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java:
##########
@@ -84,6 +84,10 @@ private void definitionLevel(int definitionLevel) {
 
   private void repetitionLevel(int repetitionLevel) {
     repetitionLevelColumn.writeInteger(repetitionLevel);
+    assert pageRowCount == 0 ? repetitionLevel == 0 : true : "Every page shall start on record boundaries";

Review Comment:
   What is the logic of adding verification here? I have encountered a situation where the valuecount is 0 but the replicationlevel is not 0. Is this situation itself normal? Why do you need to add this check after columnindex



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org