You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Justin Spears (JIRA)" <ji...@apache.org> on 2012/10/30 19:54:12 UTC
[jira] [Created] (VYSPER-331) Add Retrieve/Revoke Items
Justin Spears created VYSPER-331:
------------------------------------
Summary: Add Retrieve/Revoke Items
Key: VYSPER-331
URL: https://issues.apache.org/jira/browse/VYSPER-331
Project: VYSPER
Issue Type: Improvement
Components: XEP0060 PubSub
Affects Versions: 0.8
Reporter: Justin Spears
Priority: Minor
Attachments: pubsub.patch
Attached is a patch to add retrieve
6.5 Retrieve Items from a Node and
7.2 Delete an Item from a Node
*Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Spears updated VYSPER-331:
---------------------------------
Attachment: pubsub.patch
patch implementing 6.5/7.2
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Spears updated VYSPER-331:
---------------------------------
Attachment: (was: pubsub.patch)
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[VYSPER] Result Set Management in PubSub
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Following up on this on the dev list...
On 05.11.12 15:47, Justin Spears (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490664#comment-13490664
> ]
>
> Justin Spears edited comment on VYSPER-331 at 11/5/12 2:45 PM:
> ---------------------------------------------------------------
>
> Please add the ASL license.
>
> As far RSM, I can abstract the RSM code, to be reused elsewhere but I
> have not verified everywhere else it should be supported, rosters
> come to mind. However I don't think Vysper needs to support RSM
> everywhere to support it in the Retrieve Items. I was just
> following the spec for Retrieve Items, as that is the functionality I
> needed.
The RSM spec says: if one result uses RSM, clients can conclude it is
supported everywhere.
Patchwise I think that RSM should be a different JIRA, since I have
enough work integrating this patch (different spacing, unused imports,
etc.) already.
Bernd
[jira] [Comment Edited] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490664#comment-13490664 ]
Justin Spears edited comment on VYSPER-331 at 11/5/12 2:45 PM:
---------------------------------------------------------------
Please add the ASL license.
As far RSM, I can abstract the RSM code, to be reused elsewhere but I have not verified everywhere else it should be supported, rosters come to mind. However I don't think Vysper needs to support RSM everywhere to support it in the Retrieve Items. I was just following the spec for Retrieve Items, as that is the functionality I needed.
was (Author: jspears):
Please add the ASL license.
As far RSM, I can abstract the RSM code, to be reused elsewhere but I have not verified everywhere else it should be supported, rosters come to mind. However I don't think vypser needs to support RSM everywhere to support it in the Retrieve Items. I was just following the spec for Retrieve Items, as that is the functionality I needed.
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490664#comment-13490664 ]
Justin Spears commented on VYSPER-331:
--------------------------------------
Please add the ASL license.
As far RSM, I can abstract the RSM code, to be reused elsewhere but I have not verified everywhere else it should be supported, rosters come to mind. However I don't think vypser needs to support RSM everywhere to support it in the Retrieve Items. I was just following the spec for Retrieve Items, as that is the functionality I needed.
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487185#comment-13487185 ]
Bernd Fondermann commented on VYSPER-331:
-----------------------------------------
Thanks for the patch.
I think PubSubRetractItemsHandler and PubSubRetrieveItemsHandler are missing from the patch.
I wouldn't mind if you'd post a new full patch including those.
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Spears updated VYSPER-331:
---------------------------------
Attachment: pubsub.patch
Pub/Sub patch with, the missing files. Sorry about that had to add them to svn for svn diff to its magic.
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Spears updated VYSPER-331:
---------------------------------
Attachment: pubsub.patch
This one has the test cases also.
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490668#comment-13490668 ]
Justin Spears commented on VYSPER-331:
--------------------------------------
>From http://xmpp.org/extensions/xep-0059.html RSM
"
In Jabber Search [1], Service Discovery [2], Publish-Subscribe [3], Message Archiving [4], and probably other future XMPP extensions, it is possible to receive large dynamic result sets in response to information requests (e.g., a user directory search on a common first name or a service discovery items request sent to a Multi-User Chat [5] service).
"
"probably other future XMPP extensions", so its unbounded. I can attempt to add to these services, can we use this one as the starting point?
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Justin Spears (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Spears updated VYSPER-331:
---------------------------------
Attachment: (was: pubsub.patch)
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VYSPER-331) Add Retrieve/Revoke Items
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490473#comment-13490473 ]
Bernd Fondermann commented on VYSPER-331:
-----------------------------------------
Some files in the patch are missing the Apache LIcense Header. Q: Do you want them to be ASL'ed? - then I will add them.
You are supporting Result Set Management in retrieve. Wouldn't we need to support this in other handlers, too?
> Add Retrieve/Revoke Items
> --------------------------
>
> Key: VYSPER-331
> URL: https://issues.apache.org/jira/browse/VYSPER-331
> Project: VYSPER
> Issue Type: Improvement
> Components: XEP0060 PubSub
> Affects Versions: 0.8
> Reporter: Justin Spears
> Priority: Minor
> Attachments: pubsub.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Attached is a patch to add retrieve
> 6.5 Retrieve Items from a Node and
> 7.2 Delete an Item from a Node
> *Note it is lacking security checks on the retrieving items from a node, for my purposes its good enough, but
> should be implemented. I believe the SpecCompliance tags are correct there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira