You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2015/05/14 16:28:54 UTC
Review Request 34214: Blueprint provisioned clusters don't have
service states updated
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/
-----------------------------------------------------------
Review request for Ambari, Robert Nettleton and Sumit Mohanty.
Bugs: AMBARI-11134
https://issues.apache.org/jira/browse/AMBARI-11134
Repository: ambari
Description
-------
Clusters that are provisioned via the REST API don't have service states updated. This doesn't affect the cluster starting and being operational but in cases where a component doesn't start, it isn't possible to start the component in the UI by starting the service. Starting the individual host component will work successfully.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java e6c2f1e
ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java df87aec
Diff: https://reviews.apache.org/r/34214/diff/
Testing
-------
Functional Testing:
- Various blueprint install and scaling operations
Unit Testing:
- New unit test and all existing java tests pass
- Several known and unrelated python tests fail which are also failing on the trunk build
Results :
Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
...
----------------------------------------------------------------------
Failed tests:
ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
----------------------------------------------------------------------
Total run:740
Total errors:2
Total failures:0
Thanks,
John Speidel
Re: Review Request 34214: Blueprint provisioned clusters don't have
service states updated
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/#review83769
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On May 14, 2015, 2:28 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34214/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 2:28 p.m.)
>
>
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
>
>
> Bugs: AMBARI-11134
> https://issues.apache.org/jira/browse/AMBARI-11134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clusters that are provisioned via the REST API don't have service states updated. This doesn't affect the cluster starting and being operational but in cases where a component doesn't start, it isn't possible to start the component in the UI by starting the service. Starting the individual host component will work successfully.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java e6c2f1e
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java df87aec
>
> Diff: https://reviews.apache.org/r/34214/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> - Various blueprint install and scaling operations
>
> Unit Testing:
> - New unit test and all existing java tests pass
> - Several known and unrelated python tests fail which are also failing on the trunk build
>
> Results :
>
> Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
> ...
> ----------------------------------------------------------------------
> Failed tests:
> ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
> ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
> ----------------------------------------------------------------------
> Total run:740
> Total errors:2
> Total failures:0
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 34214: Blueprint provisioned clusters don't have
service states updated
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/#review83772
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 14, 2015, 2:28 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34214/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 2:28 p.m.)
>
>
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
>
>
> Bugs: AMBARI-11134
> https://issues.apache.org/jira/browse/AMBARI-11134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clusters that are provisioned via the REST API don't have service states updated. This doesn't affect the cluster starting and being operational but in cases where a component doesn't start, it isn't possible to start the component in the UI by starting the service. Starting the individual host component will work successfully.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java e6c2f1e
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java df87aec
>
> Diff: https://reviews.apache.org/r/34214/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> - Various blueprint install and scaling operations
>
> Unit Testing:
> - New unit test and all existing java tests pass
> - Several known and unrelated python tests fail which are also failing on the trunk build
>
> Results :
>
> Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
> ...
> ----------------------------------------------------------------------
> Failed tests:
> ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
> ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
> ----------------------------------------------------------------------
> Total run:740
> Total errors:2
> Total failures:0
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 34214: Blueprint provisioned clusters don't have
service states updated
Posted by John Speidel <js...@hortonworks.com>.
> On May 14, 2015, 2:48 p.m., Robert Nettleton wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java, line 135
> > <https://reviews.apache.org/r/34214/diff/1/?file=959340#file959340line135>
> >
> > Minor issue:
> >
> > You might want to consider using an instance of the EasyMockSupport class to create all the mocks in this test case. This would allow the test to take advantage of calls like:
> >
> > mockSupport.replayAll();
> > mockSupport.verifyAll();
> >
> > This turns to be a nice addition to EasyMock, since future changes to the test don't involve manually updating the list of mocks to verify/reply/etc.
>
> John Speidel wrote:
> Thanks for the suggestion Bob, I agree. I had thought about it but haven't used EasyMockSupport in a long time so I just went with what I knew better. Would it be acceptable to add a comment to the test case and to switch over when I update with addtional tests in the near future?
>
> Robert Nettleton wrote:
> Sure, sounds fine to me. It's definitely not something I would hold up a merge for, just something to consider for the future.
thanks Bob. I have lots of tests to add for this class and will make the switch over to EasyMockSupport shortly when I next work on the test.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/#review83771
-----------------------------------------------------------
On May 14, 2015, 2:28 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34214/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 2:28 p.m.)
>
>
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
>
>
> Bugs: AMBARI-11134
> https://issues.apache.org/jira/browse/AMBARI-11134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clusters that are provisioned via the REST API don't have service states updated. This doesn't affect the cluster starting and being operational but in cases where a component doesn't start, it isn't possible to start the component in the UI by starting the service. Starting the individual host component will work successfully.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java e6c2f1e
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java df87aec
>
> Diff: https://reviews.apache.org/r/34214/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> - Various blueprint install and scaling operations
>
> Unit Testing:
> - New unit test and all existing java tests pass
> - Several known and unrelated python tests fail which are also failing on the trunk build
>
> Results :
>
> Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
> ...
> ----------------------------------------------------------------------
> Failed tests:
> ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
> ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
> ----------------------------------------------------------------------
> Total run:740
> Total errors:2
> Total failures:0
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 34214: Blueprint provisioned clusters don't have
service states updated
Posted by Robert Nettleton <rn...@hortonworks.com>.
> On May 14, 2015, 2:48 p.m., Robert Nettleton wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java, line 135
> > <https://reviews.apache.org/r/34214/diff/1/?file=959340#file959340line135>
> >
> > Minor issue:
> >
> > You might want to consider using an instance of the EasyMockSupport class to create all the mocks in this test case. This would allow the test to take advantage of calls like:
> >
> > mockSupport.replayAll();
> > mockSupport.verifyAll();
> >
> > This turns to be a nice addition to EasyMock, since future changes to the test don't involve manually updating the list of mocks to verify/reply/etc.
>
> John Speidel wrote:
> Thanks for the suggestion Bob, I agree. I had thought about it but haven't used EasyMockSupport in a long time so I just went with what I knew better. Would it be acceptable to add a comment to the test case and to switch over when I update with addtional tests in the near future?
Sure, sounds fine to me. It's definitely not something I would hold up a merge for, just something to consider for the future.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/#review83771
-----------------------------------------------------------
On May 14, 2015, 2:28 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34214/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 2:28 p.m.)
>
>
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
>
>
> Bugs: AMBARI-11134
> https://issues.apache.org/jira/browse/AMBARI-11134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clusters that are provisioned via the REST API don't have service states updated. This doesn't affect the cluster starting and being operational but in cases where a component doesn't start, it isn't possible to start the component in the UI by starting the service. Starting the individual host component will work successfully.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java e6c2f1e
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java df87aec
>
> Diff: https://reviews.apache.org/r/34214/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> - Various blueprint install and scaling operations
>
> Unit Testing:
> - New unit test and all existing java tests pass
> - Several known and unrelated python tests fail which are also failing on the trunk build
>
> Results :
>
> Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
> ...
> ----------------------------------------------------------------------
> Failed tests:
> ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
> ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
> ----------------------------------------------------------------------
> Total run:740
> Total errors:2
> Total failures:0
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 34214: Blueprint provisioned clusters don't have
service states updated
Posted by John Speidel <js...@hortonworks.com>.
> On May 14, 2015, 2:48 p.m., Robert Nettleton wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java, line 135
> > <https://reviews.apache.org/r/34214/diff/1/?file=959340#file959340line135>
> >
> > Minor issue:
> >
> > You might want to consider using an instance of the EasyMockSupport class to create all the mocks in this test case. This would allow the test to take advantage of calls like:
> >
> > mockSupport.replayAll();
> > mockSupport.verifyAll();
> >
> > This turns to be a nice addition to EasyMock, since future changes to the test don't involve manually updating the list of mocks to verify/reply/etc.
Thanks for the suggestion Bob, I agree. I had thought about it but haven't used EasyMockSupport in a long time so I just went with what I knew better. Would it be acceptable to add a comment to the test case and to switch over when I update with addtional tests in the near future?
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/#review83771
-----------------------------------------------------------
On May 14, 2015, 2:28 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34214/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 2:28 p.m.)
>
>
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
>
>
> Bugs: AMBARI-11134
> https://issues.apache.org/jira/browse/AMBARI-11134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clusters that are provisioned via the REST API don't have service states updated. This doesn't affect the cluster starting and being operational but in cases where a component doesn't start, it isn't possible to start the component in the UI by starting the service. Starting the individual host component will work successfully.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java e6c2f1e
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java df87aec
>
> Diff: https://reviews.apache.org/r/34214/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> - Various blueprint install and scaling operations
>
> Unit Testing:
> - New unit test and all existing java tests pass
> - Several known and unrelated python tests fail which are also failing on the trunk build
>
> Results :
>
> Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
> ...
> ----------------------------------------------------------------------
> Failed tests:
> ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
> ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
> ----------------------------------------------------------------------
> Total run:740
> Total errors:2
> Total failures:0
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 34214: Blueprint provisioned clusters don't have
service states updated
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/#review83771
-----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
<https://reviews.apache.org/r/34214/#comment134837>
Minor issue:
You might want to consider using an instance of the EasyMockSupport class to create all the mocks in this test case. This would allow the test to take advantage of calls like:
mockSupport.replayAll();
mockSupport.verifyAll();
This turns to be a nice addition to EasyMock, since future changes to the test don't involve manually updating the list of mocks to verify/reply/etc.
- Robert Nettleton
On May 14, 2015, 2:28 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34214/
> -----------------------------------------------------------
>
> (Updated May 14, 2015, 2:28 p.m.)
>
>
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
>
>
> Bugs: AMBARI-11134
> https://issues.apache.org/jira/browse/AMBARI-11134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clusters that are provisioned via the REST API don't have service states updated. This doesn't affect the cluster starting and being operational but in cases where a component doesn't start, it isn't possible to start the component in the UI by starting the service. Starting the individual host component will work successfully.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java e6c2f1e
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java df87aec
>
> Diff: https://reviews.apache.org/r/34214/diff/
>
>
> Testing
> -------
>
> Functional Testing:
> - Various blueprint install and scaling operations
>
> Unit Testing:
> - New unit test and all existing java tests pass
> - Several known and unrelated python tests fail which are also failing on the trunk build
>
> Results :
>
> Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
> ...
> ----------------------------------------------------------------------
> Failed tests:
> ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
> ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
> ----------------------------------------------------------------------
> Total run:740
> Total errors:2
> Total failures:0
>
>
> Thanks,
>
> John Speidel
>
>