[GitHub] zheng-da commented on issue #10921: Test cases improvement for MKLDNN on Gluon

[GitBox <gi...@apache.org>]

zheng-da commented on issue #10921: Test cases improvement for MKLDNN on Gluon
URL: https://github.com/apache/incubator-mxnet/pull/10921#issuecomment-388640918
 
 
   @marcoabreu i agree with you that we need cpp tests for MKLDNN to explicitly cover different input and output NDArrays. I'm writing such unit tests. These tests will cover more different cases and many of them are not covered by the python unit tests. However, writing such cpp unit tests is much more difficult and probably can only be used for testing a single operator. We'll need more people to write unit tests.
   The tests on in this PR. https://github.com/apache/incubator-mxnet/pull/10651
   I'll probably split the PR and submit another PR for adding cpp unit tests.
   
   That's why the python tests can be useful. It can easily cover many different operator combinations, which may cause problems in MKLDNN and was never tested in our unit tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services