You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Devin Leamy <dl...@x.com> on 2024/02/29 23:14:39 UTC
Review Request 74919: [support/post-reviews] Add `--update-all` flag to update all diffs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74919/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Adds a flag `--update-all` that will automatically update all diffs,
without prompting the user. If the flag is not provided the user will
be prompted for every diff, like usual.
Diffs
-----
support/post-reviews.py 799f20d898f42262cd6eba8b603020b151fbe9e9
Diff: https://reviews.apache.org/r/74919/diff/1/
Testing
-------
Thanks,
Devin Leamy
Re: Review Request 74919: [support/post-reviews] Add `--update-all` flag to update all diffs.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Feb. 29, 2024, 11:18 p.m., Devin Leamy wrote:
> > support/post-reviews.py
> > Lines 357 (patched)
> > <https://reviews.apache.org/r/74919/diff/1/?file=2285641#file2285641line357>
> >
> > For some reason the string "--update-all" when converted into bytes yields b'\xe2\x80\x94-update-all' rather than b"--update-all". As a result, comparison with "--update-all" didn't work (as you'd expect) and I, thus, couldn't do what I initially wanted which was:
> >
> > `[arg for arg in sys.argv[1:] if not arg in ['--update-all']]`
> >
> > If you understand why this doesn't work, let me know!
your first dash is a em-dash: https://stackoverflow.com/a/58219209
but your other two dashes are typical ascii dashes
em-dash is 0xE2 0x80 0x94 in UTF-8
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74919/#review226275
-----------------------------------------------------------
On Feb. 29, 2024, 11:14 p.m., Devin Leamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74919/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2024, 11:14 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a flag `--update-all` that will automatically update all diffs,
> without prompting the user. If the flag is not provided the user will
> be prompted for every diff, like usual.
>
>
> Diffs
> -----
>
> support/post-reviews.py 799f20d898f42262cd6eba8b603020b151fbe9e9
>
>
> Diff: https://reviews.apache.org/r/74919/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Devin Leamy
>
>
Re: Review Request 74919: [support/post-reviews] Add `--update-all` flag to update all diffs.
Posted by Devin Leamy <dl...@x.com.INVALID>.
> On Feb. 29, 2024, 11:18 p.m., Devin Leamy wrote:
> > support/post-reviews.py
> > Lines 357 (patched)
> > <https://reviews.apache.org/r/74919/diff/1/?file=2285641#file2285641line357>
> >
> > For some reason the string "--update-all" when converted into bytes yields b'\xe2\x80\x94-update-all' rather than b"--update-all". As a result, comparison with "--update-all" didn't work (as you'd expect) and I, thus, couldn't do what I initially wanted which was:
> >
> > `[arg for arg in sys.argv[1:] if not arg in ['--update-all']]`
> >
> > If you understand why this doesn't work, let me know!
>
> Benjamin Mahler wrote:
> your first dash is a em-dash: https://stackoverflow.com/a/58219209
> but your other two dashes are typical ascii dashes
> em-dash is 0xE2 0x80 0x94 in UTF-8
Resolved. MacOS, VSCode, or something else automatically converted two slashes into an em-dash.
- Devin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74919/#review226275
-----------------------------------------------------------
On March 1, 2024, 10:52 p.m., Devin Leamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74919/
> -----------------------------------------------------------
>
> (Updated March 1, 2024, 10:52 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a flag `--update-all` that will automatically update all diffs,
> without prompting the user. If the flag is not provided the user will
> be prompted for every diff, like usual.
>
>
> Diffs
> -----
>
> support/post-reviews.py 799f20d898f42262cd6eba8b603020b151fbe9e9
>
>
> Diff: https://reviews.apache.org/r/74919/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Devin Leamy
>
>
Re: Review Request 74919: [support/post-reviews] Add `--update-all` flag to update all diffs.
Posted by Devin Leamy <dl...@x.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74919/#review226275
-----------------------------------------------------------
support/post-reviews.py
Lines 357 (patched)
<https://reviews.apache.org/r/74919/#comment314520>
For some reason the string "--update-all" when converted into bytes yields b'\xe2\x80\x94-update-all' rather than b"--update-all". As a result, comparison with "--update-all" didn't work (as you'd expect) and I, thus, couldn't do what I initially wanted which was:
`[arg for arg in sys.argv[1:] if not arg in ['--update-all']]`
If you understand why this doesn't work, let me know!
- Devin Leamy
On Feb. 29, 2024, 11:14 p.m., Devin Leamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74919/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2024, 11:14 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a flag `--update-all` that will automatically update all diffs,
> without prompting the user. If the flag is not provided the user will
> be prompted for every diff, like usual.
>
>
> Diffs
> -----
>
> support/post-reviews.py 799f20d898f42262cd6eba8b603020b151fbe9e9
>
>
> Diff: https://reviews.apache.org/r/74919/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Devin Leamy
>
>
Re: Review Request 74919: [support/post-reviews] Add `--update-all` flag to update all diffs.
Posted by Devin Leamy <dl...@x.com.INVALID>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74919/
-----------------------------------------------------------
(Updated March 1, 2024, 10:52 p.m.)
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Adds a flag `--update-all` that will automatically update all diffs,
without prompting the user. If the flag is not provided the user will
be prompted for every diff, like usual.
Diffs (updated)
-----
support/post-reviews.py 799f20d898f42262cd6eba8b603020b151fbe9e9
Diff: https://reviews.apache.org/r/74919/diff/2/
Changes: https://reviews.apache.org/r/74919/diff/1-2/
Testing
-------
Thanks,
Devin Leamy