You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2013/12/12 13:20:08 UTC
[jira] [Updated] (OAK-1274) Wrong comparison for old Revisions
[ https://issues.apache.org/jira/browse/OAK-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated OAK-1274:
----------------------------------
Attachment: OAK-1274.patch
I put the patch from the comment in a file and also updated the JavaDoc in RevisionComparator.getRevisionSeen() to reflect the current contract.
I see the test failure as well with the patch applied.
> Wrong comparison for old Revisions
> ----------------------------------
>
> Key: OAK-1274
> URL: https://issues.apache.org/jira/browse/OAK-1274
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, mongomk
> Affects Versions: 0.13
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Attachments: OAK-1274.patch
>
>
> Comparing revisions may return wrong results when one of the revision is older than the oldest revision range kept in the RevisionComparator.
> There are multiple reasons why there is no revision range for a revision.
> - The revision was created more than an hour ago and the associated range was purged from the RevisionComparator. This happens in the background thread of MongoNodeStore with a threshold of one hour.
> - The revision isn't actually that old, but still included in a range of the RevisionComparator because the MongoNodeStore instance was just initialized and only has ranges for recent revisions but not for those before the init.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)