You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/05 12:39:34 UTC

[GitHub] [couchdb-ibrowse] jiahuili430 commented on a change in pull request #5: Unquote basic auth username and password

jiahuili430 commented on a change in pull request #5:
URL: https://github.com/apache/couchdb-ibrowse/pull/5#discussion_r626527363



##########
File path: src/ibrowse_lib.erl
##########
@@ -439,4 +468,15 @@ parse_url_test() ->
               ?assertMatch(Expected_result, parse_url(Url))
       end, Urls).
 
+unquote_test() ->
+    ?assertEqual("foo bar",
+        unquote("foo+bar")),
+    ?assertEqual("foo bar",
+        unquote("foo%20bar")),
+    ?assertEqual("foo\r\n",
+        unquote("foo%0D%0A")),
+    ?assertEqual("foo\r\n",
+        unquote(<<"foo%0D%0A">>)),

Review comment:
       Thanks, @iilyak @bessbd 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org