You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/09 16:04:04 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #9496: fix: add lineWidth to Shared_DeckGL.jsx

villebro opened a new pull request #9496: fix: add lineWidth to Shared_DeckGL.jsx
URL: https://github.com/apache/incubator-superset/pull/9496
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   #9455 caused a regression by dropping `lineWidth` from the shared DeckGL controls.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   Local testing
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @rusackas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on issue #9496: fix: add lineWidth to Shared_DeckGL.jsx

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9496: fix: add lineWidth to Shared_DeckGL.jsx
URL: https://github.com/apache/incubator-superset/pull/9496#issuecomment-611719051
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9496?src=pr&el=h1) Report
   > Merging [#9496](https://codecov.io/gh/apache/incubator-superset/pull/9496?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b39e78fca5265f297f3ce318bc239eee981c4453&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9496/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9496?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9496      +/-   ##
   ==========================================
   - Coverage   58.77%   58.76%   -0.01%     
   ==========================================
     Files         385      385              
     Lines       12239    12240       +1     
     Branches     3022     3022              
   ==========================================
     Hits         7193     7193              
   - Misses       4862     4863       +1     
     Partials      184      184              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9496?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ontend/src/explore/controlPanels/Shared\_DeckGL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9496/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfRGVja0dMLmpzeA==) | `0.00% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9496?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9496?src=pr&el=footer). Last update [b39e78f...649202c](https://codecov.io/gh/apache/incubator-superset/pull/9496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas merged pull request #9496: fix: add lineWidth to Shared_DeckGL.jsx

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #9496: fix: add lineWidth to Shared_DeckGL.jsx
URL: https://github.com/apache/incubator-superset/pull/9496
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org