You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2013/04/04 15:13:10 UTC
Re: Review Request: Turn off -fvisibility=hidden for gcc 4.1.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10283/
-----------------------------------------------------------
(Updated April 4, 2013, 1:13 p.m.)
Review request for qpid, Andrew Stitcher, Alan Conway, and Steve Huston.
Summary (updated)
-----------------
Turn off -fvisibility=hidden for gcc 4.1.2
Description
-------
Reason being it causes the exception types in the qpidmessaging library to be lost.
This addresses bug QPID-4701.
https://issues.apache.org/jira/browse/QPID-4701
Diffs
-----
/trunk/qpid/cpp/src/CMakeLists.txt 1464148
Diff: https://reviews.apache.org/r/10283/diff/
Testing
-------
Passes previously failing make test on gcc 4.1.2; doesn't break anything on later gcc.
Thanks,
Gordon Sim
Re: Review Request: Turn off -fvisibility=hidden for gcc 4.1.2
Posted by Steve Huston <sh...@riverace.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10283/#review18683
-----------------------------------------------------------
Ship it!
Ship It!
- Steve Huston
On April 4, 2013, 1:13 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10283/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 1:13 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Alan Conway, and Steve Huston.
>
>
> Description
> -------
>
> Reason being it causes the exception types in the qpidmessaging library to be lost.
>
>
> This addresses bug QPID-4701.
> https://issues.apache.org/jira/browse/QPID-4701
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1464148
>
> Diff: https://reviews.apache.org/r/10283/diff/
>
>
> Testing
> -------
>
> Passes previously failing make test on gcc 4.1.2; doesn't break anything on later gcc.
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request: Turn off -fvisibility=hidden for gcc 4.1.2
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10283/#review18689
-----------------------------------------------------------
Ship it!
Ship It!
- Alan Conway
On April 4, 2013, 1:13 p.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10283/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 1:13 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Alan Conway, and Steve Huston.
>
>
> Description
> -------
>
> Reason being it causes the exception types in the qpidmessaging library to be lost.
>
>
> This addresses bug QPID-4701.
> https://issues.apache.org/jira/browse/QPID-4701
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1464148
>
> Diff: https://reviews.apache.org/r/10283/diff/
>
>
> Testing
> -------
>
> Passes previously failing make test on gcc 4.1.2; doesn't break anything on later gcc.
>
>
> Thanks,
>
> Gordon Sim
>
>