You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Sorin Silaghi (JIRA)" <de...@myfaces.apache.org> on 2007/07/27 21:58:53 UTC
[jira] Created: (MYFACES-1689) Reload of web.xml file if changes
are detected
Reload of web.xml file if changes are detected
----------------------------------------------
Key: MYFACES-1689
URL: https://issues.apache.org/jira/browse/MYFACES-1689
Project: MyFaces Core
Issue Type: Improvement
Components: General
Affects Versions: 1.1.6-SNAPSHOT
Reporter: Sorin Silaghi
Priority: Minor
Attachments: web_xml_reload.patch
This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1689) Reload of web.xml file if changes
are detected
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516654 ]
Martin Marinschek commented on MYFACES-1689:
--------------------------------------------
This looks very good now - one thing is still missing, though, I think:
The old configuration is not cleaned out - so if you have a phase-listener configured, e.g., you'll have after 10 reloads 10 active phase-listeners, unless I understand something wrongly here.
regards,
Martin
> Reload of web.xml file if changes are detected
> ----------------------------------------------
>
> Key: MYFACES-1689
> URL: https://issues.apache.org/jira/browse/MYFACES-1689
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6-SNAPSHOT
> Reporter: Sorin Silaghi
> Priority: Minor
> Attachments: faces-configuration-refresh.patch, web_xml_reload.patch
>
>
> This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1689) Reload of web.xml file if changes
are detected
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516145 ]
Martin Marinschek commented on MYFACES-1689:
--------------------------------------------
Hi Sorin,
very nice, but the faces-config.xml file reload is missing. Actually, the faces-config.xml file is the important one - cause the web.xml will mostly be read by the servlet-container, and we can't tell the servlet-container to reload its definitions. The only thing where a web.xml reload might help is for the context-parameters - but that would mean some additional handling inside MyFacesConfig, I guess, or the ServletExternalContextImpl.
regards,
Martin
> Reload of web.xml file if changes are detected
> ----------------------------------------------
>
> Key: MYFACES-1689
> URL: https://issues.apache.org/jira/browse/MYFACES-1689
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6-SNAPSHOT
> Reporter: Sorin Silaghi
> Priority: Minor
> Attachments: web_xml_reload.patch
>
>
> This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1689) Reload of faces-config-files if
changes are detected
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531053 ]
Martin Marinschek commented on MYFACES-1689:
--------------------------------------------
Also committed for 1.2 now.
regards,
Martin
> Reload of faces-config-files if changes are detected
> ----------------------------------------------------
>
> Key: MYFACES-1689
> URL: https://issues.apache.org/jira/browse/MYFACES-1689
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6-SNAPSHOT
> Reporter: Sorin Silaghi
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: 1.1.6-SNAPSHOT
>
> Attachments: faces-configuration-refresh-0.9.patch
>
>
> This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1689) Reload of faces-config-files if
changes are detected
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Marinschek updated MYFACES-1689:
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.6-SNAPSHOT
Assignee: Martin Marinschek
Status: Resolved (was: Patch Available)
> Reload of faces-config-files if changes are detected
> ----------------------------------------------------
>
> Key: MYFACES-1689
> URL: https://issues.apache.org/jira/browse/MYFACES-1689
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6-SNAPSHOT
> Reporter: Sorin Silaghi
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: 1.1.6-SNAPSHOT
>
> Attachments: faces-configuration-refresh-0.9.patch
>
>
> This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1689) Reload of web.xml file if changes
are detected
Posted by "Sorin Silaghi (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sorin Silaghi updated MYFACES-1689:
-----------------------------------
Status: Patch Available (was: Open)
> Reload of web.xml file if changes are detected
> ----------------------------------------------
>
> Key: MYFACES-1689
> URL: https://issues.apache.org/jira/browse/MYFACES-1689
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6-SNAPSHOT
> Reporter: Sorin Silaghi
> Priority: Minor
> Attachments: web_xml_reload.patch
>
>
> This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1689) Reload of web.xml file if changes
are detected
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517111 ]
Martin Marinschek commented on MYFACES-1689:
--------------------------------------------
Brilliant! I really love the results, plus played around a bit more - I'm using less static methods now (we could still clean this up a bit more, whenever someone gets time, plus also think about when/where synchronization might be necessary), and I also made sure that beans which are not there anymore are actually removed from session and application scope.
In any case, good work, Sorin - I love the effect for development - it will give us all a productivity boost.
regards,
Martin
> Reload of web.xml file if changes are detected
> ----------------------------------------------
>
> Key: MYFACES-1689
> URL: https://issues.apache.org/jira/browse/MYFACES-1689
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6-SNAPSHOT
> Reporter: Sorin Silaghi
> Priority: Minor
> Attachments: faces-configuration-refresh-0.9.patch
>
>
> This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1689) Reload of faces-config-files if
changes are detected
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517112 ]
Martin Marinschek commented on MYFACES-1689:
--------------------------------------------
Sorin,
can you do me one favor - can you checkout the MyFaces 1.2 sources, and recreate this patch for these sources as well?
regards,
Martin
> Reload of faces-config-files if changes are detected
> ----------------------------------------------------
>
> Key: MYFACES-1689
> URL: https://issues.apache.org/jira/browse/MYFACES-1689
> Project: MyFaces Core
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.1.6-SNAPSHOT
> Reporter: Sorin Silaghi
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: 1.1.6-SNAPSHOT
>
> Attachments: faces-configuration-refresh-0.9.patch
>
>
> This will check regularly for changes in the web.xml file, and reloads it if needed. The time interval can be set by means of a context parameter (default is 2 seconds right now).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.