You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/02 22:52:14 UTC

[GitHub] [incubator-superset] gaurav1999 opened a new pull request #9458: [WIP]: Simplify superset permissions

gaurav1999 opened a new pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458
 
 
   Coming from #7501 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402644586
 
 

 ##########
 File path: superset/views/annotations.py
 ##########
 @@ -46,6 +46,9 @@ class AnnotationModelView(
     SupersetModelView, DeleteMixin
 ):  # pylint: disable=too-many-ancestors
     datamodel = SQLAInterface(Annotation)
+
+    class_permission_name = "Annotation"
 
 Review comment:
   Not sure about this Output either
   
   ![Uploading Screenshot from 2020-04-03 04-30-45.png…]()
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r403758396
 
 

 ##########
 File path: superset/security/manager.py
 ##########
 @@ -95,7 +95,7 @@ def __init__(self, **kwargs):
 
 class SupersetSecurityManager(SecurityManager):
     userstatschartview = None
-    READ_ONLY_MODEL_VIEWS = {"DatabaseAsync", "DatabaseView", "DruidClusterModelView"}
 
 Review comment:
   I think, these sets are meant to have the name of a View, it might be more cleaner if we let views there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r403727066
 
 

 ##########
 File path: superset/views/database/api.py
 ##########
 @@ -113,12 +114,20 @@ class DatabaseRestApi(DatabaseMixin, BaseSupersetModelRestApi):
     datamodel = SQLAInterface(Database)
 
     include_route_methods = {"get_list", "table_metadata", "select_star"}
-    class_permission_name = "DatabaseView"
-    method_permission_name = {
+
 
 Review comment:
   @mistercrunch Had a doubt, Was wondering if this should be bundled in with the permission "Database"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 closed pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #9458:
URL: https://github.com/apache/superset/pull/9458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r403757815
 
 

 ##########
 File path: superset/security/manager.py
 ##########
 @@ -95,7 +95,7 @@ def __init__(self, **kwargs):
 
 class SupersetSecurityManager(SecurityManager):
     userstatschartview = None
-    READ_ONLY_MODEL_VIEWS = {"DatabaseAsync", "DatabaseView", "DruidClusterModelView"}
 
 Review comment:
   DruidCluserModelView do belongs to only "Datasource" permission, not sure if this is going to work. Also was wondering, if can pass the "views" in this set rather than passing the Permission name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 commented on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #9458:
URL: https://github.com/apache/superset/pull/9458#issuecomment-869662772


   closing due to inactivity


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on issue #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-608505976
 
 
   @dpgaspar 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r403089923
 
 

 ##########
 File path: superset/connectors/druid/views.py
 ##########
 @@ -190,6 +196,9 @@ class DruidMetricInlineView(CompactCRUDMixin, SupersetModelView):
 
 class DruidClusterModelView(SupersetModelView, DeleteMixin, YamlExportMixin):
     datamodel = SQLAInterface(models.DruidCluster)
+
+    class_permission_name = "DataSource"
 
 Review comment:
   sure, let me redo it
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 closed pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #9458:
URL: https://github.com/apache/superset/pull/9458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 commented on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #9458:
URL: https://github.com/apache/superset/pull/9458#issuecomment-869662772


   closing due to inactivity


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402644586
 
 

 ##########
 File path: superset/views/annotations.py
 ##########
 @@ -46,6 +46,9 @@ class AnnotationModelView(
     SupersetModelView, DeleteMixin
 ):  # pylint: disable=too-many-ancestors
     datamodel = SQLAInterface(Annotation)
+
+    class_permission_name = "Annotation"
 
 Review comment:
   Not sure about this Output either
   
   ![Screenshot from 2020-04-03 04-30-45](https://user-images.githubusercontent.com/20752142/78307648-00dec400-7564-11ea-81e4-c615c8a0c567.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402643623
 
 

 ##########
 File path: superset/views/schedules.py
 ##########
 @@ -47,6 +47,9 @@ class EmailScheduleView(
     SupersetModelView, DeleteMixin
 ):  # pylint: disable=too-many-ancestors
     include_route_methods = RouteMethod.CRUD_SET
+
+    class_permission_name = "ScheduleEmail"
 
 Review comment:
   I am unable to see this view in the Permission set.
   
   ![Screenshot from 2020-04-03 04-28-12](https://user-images.githubusercontent.com/20752142/78307452-8f9f1100-7563-11ea-9504-e32ff6d43b03.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-614627614
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b11b44abe08c131fb9df6ec479ea29c24c784ec&el=desc) will **decrease** coverage by `6.72%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9458      +/-   ##
   ==========================================
   - Coverage   65.49%   58.77%   -6.73%     
   ==========================================
     Files         571      389     -182     
     Lines       29889    12370   -17519     
     Branches     3040     3040              
   ==========================================
   - Hits        19577     7270   -12307     
   + Misses      10128     4916    -5212     
     Partials      184      184              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `58.77% <ø> (ø)` | |
   | #mysql | `?` | |
   | #postgres | `?` | |
   | #python | `?` | |
   | #sqlite | `?` | |
   | #unittest | `58.77% <ø> (-6.73%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | | |
   | [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | | |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | | |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | | |
   | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | | |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
   | [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | | |
   | [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | | |
   | [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | | |
   | ... and [155 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [7b11b44...a67ab0f](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 edited a comment on issue #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 edited a comment on issue #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-608133313
 
 
   Right now, I can see the permissions which I added/edited but problem is, the older permissions still exists, they are not removed for some reason :-( . 
   
   For example:
   
   On searching: SliceModelView
   
   ![Screenshot from 2020-04-03 04-10-01](https://user-images.githubusercontent.com/20752142/78307199-07207080-7563-11ea-8d49-ef1302e98071.png)
   
   On Searching: Chart
   
   ![Screenshot from 2020-04-03 04-09-37](https://user-images.githubusercontent.com/20752142/78307200-08519d80-7563-11ea-958a-bb4c792ec613.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r403723192
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -998,7 +998,7 @@ def save_or_overwrite_slice(
             )
         elif request.args.get("add_to_dash") == "new":
             # check create dashboard permissions
-            dash_add_perm = security_manager.can_access("can_add", "DashboardModelView")
+            dash_add_perm = security_manager.can_access("can_write", "DashboardModelView")
 
 Review comment:
   I think I missed this one

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r403084293
 
 

 ##########
 File path: superset/connectors/druid/views.py
 ##########
 @@ -190,6 +196,9 @@ class DruidMetricInlineView(CompactCRUDMixin, SupersetModelView):
 
 class DruidClusterModelView(SupersetModelView, DeleteMixin, YamlExportMixin):
     datamodel = SQLAInterface(models.DruidCluster)
+
+    class_permission_name = "DataSource"
 
 Review comment:
   case is different

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-608132955
 
 
   @mistercrunch , I wish to finish the TODO's in #7501 , also will remove my author name from commit, as this is your work. If you say I can edit this MR for your branch.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402645003
 
 

 ##########
 File path: superset/connectors/sqla/views.py
 ##########
 @@ -167,6 +170,9 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView):
 
 class SqlMetricInlineView(CompactCRUDMixin, SupersetModelView):
     datamodel = SQLAInterface(models.SqlMetric)
+
+    class_permission_name = "Datasource"
 
 Review comment:
   Same as below, I have "Datasource" permission visible, but the older one still persists.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on a change in pull request #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#discussion_r402644192
 
 

 ##########
 File path: superset/views/chart/views.py
 ##########
 @@ -33,6 +33,7 @@ class SliceModelView(
     SliceMixin, SupersetModelView, DeleteMixin
 ):  # pylint: disable=too-many-ancestors
     route_base = "/chart"
+    class_permission_name = "Chart"
 
 Review comment:
   This comes out okay, but the previous permission still persists.
   ![Screenshot from 2020-04-03 04-29-21](https://user-images.githubusercontent.com/20752142/78307515-b52c1a80-7563-11ea-9795-e552d575323c.png)
   ![Screenshot from 2020-04-03 04-29-49](https://user-images.githubusercontent.com/20752142/78307550-c8d78100-7563-11ea-9610-8663e784f8c4.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
gaurav1999 commented on issue #9458: [WIP]: Simplify superset permissions
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-608133313
 
 
   Right now, I can see the permissions which I added/edited but problem is, the older permissions still exists, they are not removed for some reason :-( . 
   
   For example:
   ![Screenshot from 2020-04-03 04-10-01](https://user-images.githubusercontent.com/20752142/78307199-07207080-7563-11ea-8d49-ef1302e98071.png)
   ![Screenshot from 2020-04-03 04-09-37](https://user-images.githubusercontent.com/20752142/78307200-08519d80-7563-11ea-958a-bb4c792ec613.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-631569469


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/656cdfb86709fa525c1122e359d2e767c6174351&el=desc) will **increase** coverage by `0.59%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9458      +/-   ##
   ==========================================
   + Coverage   70.39%   70.98%   +0.59%     
   ==========================================
     Files         585      401     -184     
     Lines       31042    12840   -18202     
     Branches     3277     3277              
   ==========================================
   - Hits        21853     9115   -12738     
   + Misses       9078     3614    -5464     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.86% <ø> (+<0.01%)` | :arrow_up: |
   | #javascript | `59.36% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | | |
   | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
   | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | | |
   | [superset/db\_engine\_specs/exasol.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2V4YXNvbC5weQ==) | | |
   | [superset/dao/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | | |
   | [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | | |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | | |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
   | ... and [158 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [656cdfb...360983a](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-614627614






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-631569469


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/656cdfb86709fa525c1122e359d2e767c6174351&el=desc) will **decrease** coverage by `11.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9458       +/-   ##
   ===========================================
   - Coverage   70.39%   59.36%   -11.03%     
   ===========================================
     Files         585      401      -184     
     Lines       31042    12840    -18202     
     Branches     3277     3277               
   ===========================================
   - Hits        21853     7623    -14230     
   + Misses       9078     5036     -4042     
   - Partials      111      181       +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.36% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [304 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [656cdfb...360983a](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-614627614


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `4.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9458      +/-   ##
   ==========================================
   + Coverage   65.70%   70.38%   +4.67%     
   ==========================================
     Files         581      399     -182     
     Lines       30219    12464   -17755     
     Branches     3071     3071              
   ==========================================
   - Hits        19856     8773   -11083     
   + Misses      10182     3579    -6603     
   + Partials      181      112      -69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.63% <ø> (?)` | |
   | #javascript | `58.74% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
   | [superset/utils/dates.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZXMucHk=) | | |
   | [superset/dao/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2V4Y2VwdGlvbnMucHk=) | | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
   | [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | | |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
   | [...migrations/versions/fb13d49b72f9\_better\_filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mYjEzZDQ5YjcyZjlfYmV0dGVyX2ZpbHRlcnMucHk=) | | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | | |
   | [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
   | ... and [299 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [f07ca7d...e3653a5](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-631569469


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/656cdfb86709fa525c1122e359d2e767c6174351&el=desc) will **increase** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9458      +/-   ##
   ==========================================
   + Coverage   70.39%   70.50%   +0.10%     
   ==========================================
     Files         585      401     -184     
     Lines       31042    12840   -18202     
     Branches     3277     3277              
   ==========================================
   - Hits        21853     9053   -12800     
   + Misses       9078     3670    -5408     
   - Partials      111      117       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.08% <ø> (-0.78%)` | :arrow_down: |
   | #javascript | `59.36% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | | |
   | ... and [167 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [656cdfb...360983a](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-614627614


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `4.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9458      +/-   ##
   ==========================================
   + Coverage   65.70%   69.88%   +4.18%     
   ==========================================
     Files         581      399     -182     
     Lines       30219    12464   -17755     
     Branches     3071     3071              
   ==========================================
   - Hits        19856     8711   -11145     
   + Misses      10182     3635    -6547     
   + Partials      181      118      -63     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `52.83% <ø> (?)` | |
   | #javascript | `58.74% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | | |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | | |
   | [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | | |
   | [superset/examples/multi\_line.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | | |
   | [superset/datasets/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | | |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | | |
   | [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | | |
   | [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | | |
   | ... and [297 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [f07ca7d...e3653a5](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-670838349


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-631569469


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f1208f510ceda24654dca794cf04a33aa234cc5&el=desc) will **decrease** coverage by `11.64%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9458       +/-   ##
   ===========================================
   - Coverage   70.94%   59.30%   -11.65%     
   ===========================================
     Files         588      404      -184     
     Lines       30609    12741    -17868     
     Branches     3238     3238               
   ===========================================
   - Hits        21717     7556    -14161     
   + Misses       8780     4998     -3782     
   - Partials      112      187       +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [306 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [6f1208f...f3a16b5](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9458: [WIP]: Simplify superset permissions

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9458:
URL: https://github.com/apache/incubator-superset/pull/9458#issuecomment-614627614


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=h1) Report
   > Merging [#9458](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **decrease** coverage by `6.96%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9458/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9458      +/-   ##
   ==========================================
   - Coverage   65.70%   58.74%   -6.97%     
   ==========================================
     Files         581      399     -182     
     Lines       30219    12464   -17755     
     Branches     3071     3071              
   ==========================================
   - Hits        19856     7322   -12534     
   + Misses      10182     4961    -5221     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `58.74% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | | |
   | [superset/utils/logging\_configurator.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nZ2luZ19jb25maWd1cmF0b3IucHk=) | | |
   | [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | | |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | | |
   | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | | |
   | [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
   | [superset/models/datasource\_access\_request.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2RhdGFzb3VyY2VfYWNjZXNzX3JlcXVlc3QucHk=) | | |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | | |
   | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | | |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | | |
   | ... and [155 more](https://codecov.io/gh/apache/incubator-superset/pull/9458/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=footer). Last update [f07ca7d...e3653a5](https://codecov.io/gh/apache/incubator-superset/pull/9458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org