You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/18 16:09:58 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #7326:
[annotations] Improves annotation validation, start_dttm, end_dttm
dpgaspar opened a new pull request #7326: [annotations] Improves annotation validation, start_dttm, end_dttm
URL: https://github.com/apache/incubator-superset/pull/7326
### CATEGORY
Choose one
- [x] Enhancement (new features, refinement)
### SUMMARY
Annotations are using ``pre_add`` callback to validate form fields, the users need to refill the form
if ``start_dttm`` and/or ``end_dttm`` validation fails. Using a custom WTForm validation object
improves the user experience because the form is validated before leaving the page, and
fields are highlighted with the error message
### ADDITIONAL INFORMATION
- [x] Changes UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org