You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/03 08:25:07 UTC
[GitHub] [incubator-kyuubi] bowenliang123 commented on pull request #3891: [KYUUBI #3890] [Improvement] Prefer `binPack` style for importSelectors in scalafmt styling
bowenliang123 commented on PR #3891:
URL: https://github.com/apache/incubator-kyuubi/pull/3891#issuecomment-1336112706
Let me try to explain this PR in some more reasons,
1. `singleLine` style for imports does force the line of long imports to break `maxColumn` rule, which is not self-explicable and brings worse readability in practical use
2. long imports are unavoidable in some cases, or using `import any._` with wildcard will cause cyclic dependencies (e.g. v2commands.scala as the example the issue mentioned)
3. `binPack` style won't impact the multi-imports which is not over-sized
4. `binPack` sytle is the original capability from `scalafmt`, and wont introduced extra mannual workload for auto linting and reformat using IDE or tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org