You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Benedict (JIRA)" <ji...@apache.org> on 2015/05/26 09:10:17 UTC

[jira] [Commented] (CASSANDRA-9473) Introduce BTreeSet with support for in-place reversal

    [ https://issues.apache.org/jira/browse/CASSANDRA-9473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558767#comment-14558767 ] 

Benedict commented on CASSANDRA-9473:
-------------------------------------

Just noticed this is still present in the codebase, even though it is only used for tests. So all we need is a Builder, and it swap it into all of the places we currently employ TreeSet (except those that do in-place modification)

> Introduce BTreeSet with support for in-place reversal
> -----------------------------------------------------
>
>                 Key: CASSANDRA-9473
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9473
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.x
>
>
> Follow up to CASSANDRA-8099.
> We use TreeSet in a lot of places unnecessarily. This is especially a concern now that we store the set of rows we're searching for in both forward and (potentially) reverse order, which we have to construct twice. A very simple wrapper around BTree (which we had previously, but did not employ) would permit us to reverse this collection without any extra work, can be built more cheaply, consumes less memory, and supports the SearchIterator interface, so can be iterated more efficiently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)