You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "flycash (GitHub)" <gi...@apache.org> on 2020/01/26 15:20:08 UTC
[GitHub] [dubbo-go] flycash opened pull request #342:
Feature/prometheus
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Creating a MetricsFilter to collect the invocation' information.
Now we support the summary.
The counter, historgram... need to be developed in future.
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls use func name as the first comment word. And the following funcs' name should also appear on their comments.
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "zouyx (GitHub)" <gi...@apache.org>.
i am not sugger instance in ```config/config_loader.go```, but get method in ```config/application_config.go```, should put them in the same file.
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #342: Ftr: Prometheus Support —— Summary
Posted by "flycash (GitHub)" <gi...@apache.org>.
Because of even the `metricConfig` is created twice, it won't be a problem. The metricConfig is initialized when the system start.
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@83d3ca6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `67.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
==========================================
Coverage ? 66.35%
==========================================
Files ? 139
Lines ? 7814
Branches ? 0
==========================================
Hits ? 5185
Misses ? 2135
Partials ? 494
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `52.77% <ø> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `100% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `51.92% <ø> (ø)` | |
| [config/metric\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL21ldHJpY19jb25maWcuZ28=) | `0% <ø> (ø)` | |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `41.66% <ø> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.55% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `67.91% <100%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `53.25% <37.5%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.46% <77.77%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [83d3ca6...6404fbb](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> Merging [#342](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/5a71b395da8ebedcae739469d0e1aaa63d63b60e?src=pr&el=desc) will **decrease** coverage by `0.5%`.
> The diff coverage is `83.52%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
===========================================
- Coverage 66.05% 65.54% -0.51%
===========================================
Files 123 139 +16
Lines 7623 7808 +185
===========================================
+ Hits 5035 5118 +83
- Misses 2097 2194 +97
- Partials 491 496 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `63.95% <ø> (ø)` | :arrow_up: |
| [config/metric\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL21ldHJpY19jb25maWcuZ28=) | `100% <100%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `59.52% <100%> (+0.98%)` | :arrow_up: |
| [common/extension/metrics.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRyaWNzLmdv) | `71.42% <71.42%> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `82% <82%> (ø)` | |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `86.36% <86.36%> (ø)` | |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `70.27% <0%> (-5.41%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0%> (-2.44%)` | :arrow_down: |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0% <0%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [5a71b39...8ceeefd](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> Merging [#342](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/6404fbbbe737470061ae4cccbc0d5062d0fe47d5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
========================================
Coverage 66.32% 66.32%
========================================
Files 139 139
Lines 7814 7814
========================================
Hits 5183 5183
Misses 2137 2137
Partials 494 494
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [6404fbb...229e027](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls use func name as the first comment word.
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> Merging [#342](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/229e027fbe892c9916554dec5ffa0f27d6c07d4b?src=pr&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `73.33%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
===========================================
- Coverage 66.25% 66.04% -0.22%
===========================================
Files 139 139
Lines 7830 7845 +15
===========================================
- Hits 5188 5181 -7
- Misses 2147 2164 +17
- Partials 495 500 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | `40% <ø> (ø)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.55% <ø> (ø)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.02% <20%> (-1.24%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.06% <80%> (+0.14%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `70.27% <0%> (-5.41%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.83% <0%> (-5.41%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `77.67% <0%> (-4.66%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0%> (-2.44%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `51.51% <0%> (+1.01%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `72.46% <0%> (+10.14%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [229e027...31ca039](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> Merging [#342](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/5a71b395da8ebedcae739469d0e1aaa63d63b60e?src=pr&el=desc) will **decrease** coverage by `0.47%`.
> The diff coverage is `77.17%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
===========================================
- Coverage 66.05% 65.57% -0.48%
===========================================
Files 123 139 +16
Lines 7623 7815 +192
===========================================
+ Hits 5035 5125 +90
- Misses 2097 2194 +97
- Partials 491 496 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `63.95% <ø> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `59.52% <100%> (+0.98%)` | :arrow_up: |
| [config/metric\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL21ldHJpY19jb25maWcuZ28=) | `36.36% <36.36%> (ø)` | |
| [common/extension/metrics.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRyaWNzLmdv) | `71.42% <71.42%> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `82% <82%> (ø)` | |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `86.36% <86.36%> (ø)` | |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `70.27% <0%> (-5.41%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `68.29% <0%> (-2.44%)` | :arrow_down: |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0% <0%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [5a71b39...061eb82](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@83d3ca6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `67.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
==========================================
Coverage ? 66.35%
==========================================
Files ? 139
Lines ? 7814
Branches ? 0
==========================================
Hits ? 5185
Misses ? 2135
Partials ? 494
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `52.77% <ø> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `100% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `51.92% <ø> (ø)` | |
| [config/metric\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL21ldHJpY19jb25maWcuZ28=) | `0% <ø> (ø)` | |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `41.66% <ø> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.55% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `67.91% <100%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `53.25% <37.5%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.46% <77.77%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [83d3ca6...d4ee2bf](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "zouyx (GitHub)" <gi...@apache.org>.
layout of public method comment, like :
```
// SetMetricReporter set a reporter with the name
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@83d3ca6`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
==========================================
Coverage ? 66.32%
==========================================
Files ? 139
Lines ? 7814
Branches ? 0
==========================================
Hits ? 5183
Misses ? 2136
Partials ? 495
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `100% <ø> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.55% <ø> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `67.91% <100%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/342/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `53.25% <37.5%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [83d3ca6...d4ee2bf](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #342: Ftr: Prometheus Support —— Summary & Histogram
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=h1) Report
> Merging [#342](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/229e027fbe892c9916554dec5ffa0f27d6c07d4b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #342 +/- ##
========================================
Coverage 66.25% 66.25%
========================================
Files 139 139
Lines 7830 7830
========================================
Hits 5188 5188
Misses 2147 2147
Partials 495 495
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=footer). Last update [229e027...31ca039](https://codecov.io/gh/apache/dubbo-go/pull/342?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/342 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org