You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "volatilemolotov (via GitHub)" <gi...@apache.org> on 2023/10/16 14:02:28 UTC
[PR] adding metrics report [beam]
volatilemolotov opened a new pull request, #29010:
URL: https://github.com/apache/beam/pull/29010
Adds metrics report to GH actions.
Waiting on approval for the mail action.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #29010:
URL: https://github.com/apache/beam/pull/29010#discussion_r1361191534
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
Review Comment:
Fixed
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
Review Comment:
Yes, they should wait for us in the Apache repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #29010:
URL: https://github.com/apache/beam/pull/29010#issuecomment-1767125753
This should work once https://issues.apache.org/jira/browse/INFRA-25086 (not world visible) is resolved. Infra had some questions about the usage of the action, thus the delay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #29010:
URL: https://github.com/apache/beam/pull/29010#discussion_r1361193481
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
+ - name: Archive Report
+ uses: actions/upload-artifact@v3
+ with:
+ name: Metrics Report
+ path: ".test-infra/jenkins/metrics_report/beam-metrics_report.html"
+ - name: Generate Date
+ run: |
+ date=$(date -u +"%Y-%m-%d")
+ echo "date=$date" >> $GITHUB_ENV
+ - name: Send mail
+ uses: dawidd6/action-send-mail@v3
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_ADDRESS }}
+ password: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_PASSWORD }}
+ subject: Beam Metrics Report ${{ env.date }}
+ to: dannymccormick@google.com #dev@beam.apache.org
+ cc: vlado.djerek@akvelon.com
Review Comment:
We are specifying both to: and cc: in this case. This is temporary so that it can be tested once merged and action is approved (notice that only wokflow_dispatch trigger is enabled for now). After that there will be only to: dev@...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #29010:
URL: https://github.com/apache/beam/pull/29010#discussion_r1361192137
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
+ - name: Archive Report
+ uses: actions/upload-artifact@v3
+ with:
+ name: Metrics Report
+ path: ".test-infra/jenkins/metrics_report/beam-metrics_report.html"
+ - name: Generate Date
+ run: |
+ date=$(date -u +"%Y-%m-%d")
+ echo "date=$date" >> $GITHUB_ENV
+ - name: Send mail
+ uses: dawidd6/action-send-mail@v3
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_ADDRESS }}
+ password: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_PASSWORD }}
+ subject: Beam Metrics Report ${{ env.date }}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29010:
URL: https://github.com/apache/beam/pull/29010#issuecomment-1766493273
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #29010:
URL: https://github.com/apache/beam/pull/29010#discussion_r1360719464
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
Review Comment:
Since there is no `pull_request_target` even it should be simplified:
```suggestion
group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}'
```
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
Review Comment:
Should it be `100` in accordance with the Jenkins job?
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
Review Comment:
This is redundant
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
+ - name: Archive Report
+ uses: actions/upload-artifact@v3
+ with:
+ name: Metrics Report
+ path: ".test-infra/jenkins/metrics_report/beam-metrics_report.html"
Review Comment:
I think it makes sense to specify an absolute path
```suggestion
path: "${{ github.workspace }}/.test-infra/jenkins/metrics_report/beam-metrics_report.html"
```
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
+ - name: Archive Report
+ uses: actions/upload-artifact@v3
+ with:
+ name: Metrics Report
+ path: ".test-infra/jenkins/metrics_report/beam-metrics_report.html"
+ - name: Generate Date
+ run: |
+ date=$(date -u +"%Y-%m-%d")
+ echo "date=$date" >> $GITHUB_ENV
+ - name: Send mail
+ uses: dawidd6/action-send-mail@v3
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_ADDRESS }}
+ password: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_PASSWORD }}
+ subject: Beam Metrics Report ${{ env.date }}
Review Comment:
```suggestion
subject: Beam Metrics Report ${{ env.date }}
```
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
Review Comment:
Do we have these secrets specified?
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
+ - name: Archive Report
+ uses: actions/upload-artifact@v3
+ with:
+ name: Metrics Report
+ path: ".test-infra/jenkins/metrics_report/beam-metrics_report.html"
+ - name: Generate Date
+ run: |
+ date=$(date -u +"%Y-%m-%d")
+ echo "date=$date" >> $GITHUB_ENV
+ - name: Send mail
+ uses: dawidd6/action-send-mail@v3
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_ADDRESS }}
+ password: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_PASSWORD }}
+ subject: Beam Metrics Report ${{ env.date }}
+ to: dannymccormick@google.com #dev@beam.apache.org
+ cc: vlado.djerek@akvelon.com
+ from: gactions@beam.apache.org # <us...@example.com>
+ html_body: file://.test-infra/jenkins/metrics_report/beam-metrics_report.html
Review Comment:
I think it makes sense to specify an absolute path
```suggestion
html_body: file://${{ github.workspace }}/.test-infra/jenkins/metrics_report/beam-metrics_report.html
```
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,115 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 120
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Run Metrics Report
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :beam-test-jenkins:generateMetricsReport
+ arguments: --info -PinfluxDb=beam_test_metrics -PinfluxHost='10.128.0.96' -PinfluxPort=8086
+ env:
+ INFLUXDB_USER: ${{ secrets.INFLUXDB_USER }}
+ INFLUXDB_USER_PASSWORD: ${{ secrets.INFLUXDB_USER_PASSWORD }}
+ - name: Archive Report
+ uses: actions/upload-artifact@v3
+ with:
+ name: Metrics Report
+ path: ".test-infra/jenkins/metrics_report/beam-metrics_report.html"
+ - name: Generate Date
+ run: |
+ date=$(date -u +"%Y-%m-%d")
+ echo "date=$date" >> $GITHUB_ENV
+ - name: Send mail
+ uses: dawidd6/action-send-mail@v3
+ with:
+ server_address: smtp.gmail.com
+ server_port: 465
+ secure: true
+ username: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_ADDRESS }}
+ password: ${{ secrets.ISSUE_REPORT_SENDER_EMAIL_PASSWORD }}
+ subject: Beam Metrics Report ${{ env.date }}
+ to: dannymccormick@google.com #dev@beam.apache.org
+ cc: vlado.djerek@akvelon.com
Review Comment:
Not sure that we need to send a copy.
Can we specify the actual `to`? If no what is the next step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #29010:
URL: https://github.com/apache/beam/pull/29010#discussion_r1361929232
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Beam Metrics Report
+
+on:
+ # issue_comment:
+ # types: [created]
+ # schedule:
+ # - cron: '0 */23 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_Metrics_Report:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 100
+ strategy:
+ matrix:
+ job_name: [beam_Metrics_Report]
+ job_phrase: [Run Metrics Report]
+ if: |
+ github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event.comment.body == 'Run Metrics Report'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Generate a token
+ id: generate_token
+ uses: actions/create-github-app-token@v1
+ with:
+ app_id: ${{ secrets.GH_APP_ID }}
+ private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ steps.generate_token.outputs.token }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ steps_context: ${{ toJson(steps) }}
+ - name: Install Python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
Review Comment:
Can we use `setup-environment-action` instead?
```suggestion
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
python-version: 3.8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] adding metrics report [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #29010:
URL: https://github.com/apache/beam/pull/29010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org