You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Bryan Beaudreault (Jira)" <ji...@apache.org> on 2024/01/25 13:32:00 UTC

[jira] [Resolved] (HBASE-28327) Add remove(String key, Metric metric) method to MetricRegistry interface

     [ https://issues.apache.org/jira/browse/HBASE-28327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Beaudreault resolved HBASE-28327.
---------------------------------------
    Fix Version/s: 2.6.0
                   2.5.8
                   3.0.0-beta-2
       Resolution: Fixed

Pushed to all active branches. Thanks for the contribution [~eboland148]!

> Add remove(String key, Metric metric) method to MetricRegistry interface
> ------------------------------------------------------------------------
>
>                 Key: HBASE-28327
>                 URL: https://issues.apache.org/jira/browse/HBASE-28327
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Evelyn Boland
>            Assignee: Evelyn Boland
>            Priority: Major
>             Fix For: 2.6.0, 2.5.8, 3.0.0-beta-2
>
>
> Add a `remove(String name, Metric metric)` method to the `MetricRegistry` interface. Right now the interface only contains a `remove(String name)` method.
> This additional remove method will give users the power to remove a `Metric` with the specified `name` from the metric registry if and only if the provided `metric` matches the object in the registry.
> Implementing the new `remove(String name, Metric metric)` should be straight forward because the `MetricRegistryImpl` class stores metrics in a `ConcurrentMap`, which already contains a `remove(Object key, Object value)` method
> This change will not be a breaking one because the interface is marked with `@IntefaceStability.Evolving`
> [~rmdmattingly]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)