You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/05/18 09:52:52 UTC
[GitHub] [camel] JiriOndrusek opened a new pull request, #7633: AMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
JiriOndrusek opened a new pull request, #7633:
URL: https://github.com/apache/camel/pull/7633
fixes https://issues.apache.org/jira/browse/CAMEL-18123
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #7633: AMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #7633:
URL: https://github.com/apache/camel/pull/7633#discussion_r875702456
##########
components/camel-aws/camel-aws2-sqs/src/test/java/org/apache/camel/component/aws2/sqs/AmazonSQSClientMock.java:
##########
@@ -67,10 +67,15 @@ public class AmazonSQSClientMock implements SqsClient {
private Map<String, CreateQueueRequest> queues = new LinkedHashMap<>();
private Map<String, ScheduledFuture<?>> inFlight = new LinkedHashMap<>();
private ScheduledExecutorService scheduler;
+ private String queueuName = null;
Review Comment:
a little typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #7633: CAMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #7633:
URL: https://github.com/apache/camel/pull/7633#issuecomment-1129810720
Please also amend the commit message with the correct JIRA Issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #7633: CAMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #7633:
URL: https://github.com/apache/camel/pull/7633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] JiriOndrusek commented on a diff in pull request #7633: CAMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on code in PR #7633:
URL: https://github.com/apache/camel/pull/7633#discussion_r875708311
##########
components/camel-aws/camel-aws2-sqs/src/test/java/org/apache/camel/component/aws2/sqs/AmazonSQSClientMock.java:
##########
@@ -67,10 +67,15 @@ public class AmazonSQSClientMock implements SqsClient {
private Map<String, CreateQueueRequest> queues = new LinkedHashMap<>();
private Map<String, ScheduledFuture<?>> inFlight = new LinkedHashMap<>();
private ScheduledExecutorService scheduler;
+ private String queueuName = null;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7633: AMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7633:
URL: https://github.com/apache/camel/pull/7633#issuecomment-1129809212
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7633: CAMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7633:
URL: https://github.com/apache/camel/pull/7633#issuecomment-1129868900
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] JiriOndrusek commented on pull request #7633: CAMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #7633:
URL: https://github.com/apache/camel/pull/7633#issuecomment-1129811885
yes, I'll fix it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] JiriOndrusek commented on pull request #7633: AMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on PR #7633:
URL: https://github.com/apache/camel/pull/7633#issuecomment-1129808038
Should be backported also to 3.14.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7633: CAMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7633:
URL: https://github.com/apache/camel/pull/7633#issuecomment-1129853654
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7633: CAMEL-18123 Aws2-sqs: Operations Purge and Delete requires header
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7633:
URL: https://github.com/apache/camel/pull/7633#issuecomment-1129885801
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org