You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/18 09:48:21 UTC
[GitHub] tillrohrmann commented on a change in pull request #6872:
[FLINK-10436] Add ConfigOption#withFallbackKeys
tillrohrmann commented on a change in pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872#discussion_r226239939
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
##########
@@ -701,12 +701,14 @@ public boolean contains(ConfigOption<?> configOption) {
if (this.confData.containsKey(configOption.key())) {
return true;
}
- else if (configOption.hasDeprecatedKeys()) {
- // try the deprecated keys
- for (String deprecatedKey : configOption.deprecatedKeys()) {
- if (this.confData.containsKey(deprecatedKey)) {
- LOG.warn("Config uses deprecated configuration key '{}' instead of proper key '{}'",
- deprecatedKey, configOption.key());
+ else if (configOption.hasFallbackKeys()) {
+ // try the fallback keys
+ for (FallbackKey fallbackKey : configOption.fallbackKeys()) {
+ if (this.confData.containsKey(fallbackKey.getKey())) {
+ if (fallbackKey.isDeprecated()) {
Review comment:
Maybe it would be a good idea to log on `info` if we fall back to another key if `fallbackKey.isDeprecated == false`. That way, the user knows from which option it has read the value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services