You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/11 15:53:27 UTC
[GitHub] [arrow-adbc] lidavidm opened a new pull request, #62: [Format][C][Java] Add method to get parameter schema
lidavidm opened a new pull request, #62:
URL: https://github.com/apache/arrow-adbc/pull/62
Fixes #60.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #62: [Format][C][Java] Add method to get parameter schema
Posted by GitBox <gi...@apache.org>.
zeroshade commented on code in PR #62:
URL: https://github.com/apache/arrow-adbc/pull/62#discussion_r944512305
##########
adbc.h:
##########
@@ -746,6 +746,22 @@ AdbcStatusCode AdbcStatementBindStream(struct AdbcStatement* statement,
struct ArrowArrayStream* values,
struct AdbcError* error);
+/// \brief Get the schema for bound parameters.
+///
+/// This should be called after AdbcStatementPrepare. This retrieves
+/// an Arrow schema describing the number, names, and types of the
+/// parameters in a parameterized statement. Not all drivers will
+/// support this. If the name of a parameter cannot be determined,
+/// the name of the corresponding field in the schema will be an empty
+/// string. Similarly, if the type cannot be statically determined,
+/// the type of the corresponding field will be NA (NullType).
Review Comment:
should we also explicitly state/define that the order of the columns in the schema should match the ordinal position of the parameters and if a named parameter is used multiple times in the query, it should only appear once in the schema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on pull request #62: [Format][C][Java] Add method to get parameter schema
Posted by GitBox <gi...@apache.org>.
zeroshade commented on PR #62:
URL: https://github.com/apache/arrow-adbc/pull/62#issuecomment-1213241281
:shipit:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #62: [Format][C][Java] Add method to get parameter schema
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #62:
URL: https://github.com/apache/arrow-adbc/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #62: [Format][C][Java] Add method to get parameter schema
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #62:
URL: https://github.com/apache/arrow-adbc/pull/62#discussion_r944581552
##########
adbc.h:
##########
@@ -746,6 +746,22 @@ AdbcStatusCode AdbcStatementBindStream(struct AdbcStatement* statement,
struct ArrowArrayStream* values,
struct AdbcError* error);
+/// \brief Get the schema for bound parameters.
+///
+/// This should be called after AdbcStatementPrepare. This retrieves
+/// an Arrow schema describing the number, names, and types of the
+/// parameters in a parameterized statement. Not all drivers will
+/// support this. If the name of a parameter cannot be determined,
+/// the name of the corresponding field in the schema will be an empty
+/// string. Similarly, if the type cannot be statically determined,
+/// the type of the corresponding field will be NA (NullType).
Review Comment:
Good idea - updated the docstrings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on pull request #62: [Format][C][Java] Add method to get parameter schema
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #62:
URL: https://github.com/apache/arrow-adbc/pull/62#issuecomment-1213030715
@zeroshade does this seem reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org