You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/29 18:33:41 UTC
[GitHub] [camel] ludovic-boutros opened a new pull request #4535: CAMEL-15772: camel-pulsar readCompacted support
ludovic-boutros opened a new pull request #4535:
URL: https://github.com/apache/camel/pull/4535
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ludovic-boutros commented on pull request #4535: CAMEL-15772: camel-pulsar readCompacted support
Posted by GitBox <gi...@apache.org>.
ludovic-boutros commented on pull request #4535:
URL: https://github.com/apache/camel/pull/4535#issuecomment-718946785
Should be ok now :) thx !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ludovic-boutros commented on pull request #4535: CAMEL-15772: camel-pulsar readCompacted support
Posted by GitBox <gi...@apache.org>.
ludovic-boutros commented on pull request #4535:
URL: https://github.com/apache/camel/pull/4535#issuecomment-718992676
I need to fully rebuild the project in order to commit this file :
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/pulsar.json
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ludovic-boutros commented on a change in pull request #4535: CAMEL-15772: camel-pulsar readCompacted support
Posted by GitBox <gi...@apache.org>.
ludovic-boutros commented on a change in pull request #4535:
URL: https://github.com/apache/camel/pull/4535#discussion_r514485284
##########
File path: components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/PulsarConfiguration.java
##########
@@ -63,6 +63,8 @@
private long ackGroupTimeMillis = 100;
@UriParam(label = "consumer", defaultValue = "LATEST")
private SubscriptionInitialPosition subscriptionInitialPosition = LATEST;
+ @UriParam(label = "consumer", defaultValue = "false")
+ private boolean readCompacted = false;
Review comment:
done. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4535: CAMEL-15772: camel-pulsar readCompacted support
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4535:
URL: https://github.com/apache/camel/pull/4535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ludovic-boutros commented on pull request #4535: CAMEL-15772: camel-pulsar readCompacted support
Posted by GitBox <gi...@apache.org>.
ludovic-boutros commented on pull request #4535:
URL: https://github.com/apache/camel/pull/4535#issuecomment-719057879
It's good now, all checks have passed \o/ 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #4535: CAMEL-15772: camel-pulsar readCompacted support
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4535:
URL: https://github.com/apache/camel/pull/4535#discussion_r514482144
##########
File path: components/camel-pulsar/src/main/java/org/apache/camel/component/pulsar/PulsarConfiguration.java
##########
@@ -63,6 +63,8 @@
private long ackGroupTimeMillis = 100;
@UriParam(label = "consumer", defaultValue = "LATEST")
private SubscriptionInitialPosition subscriptionInitialPosition = LATEST;
+ @UriParam(label = "consumer", defaultValue = "false")
+ private boolean readCompacted = false;
Review comment:
The defaultValue at field level is not needed, it is false by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org