[GitHub] [madlib] kaknikhil commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA

[GitBox <gi...@apache.org>]

kaknikhil commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA
URL: https://github.com/apache/madlib/pull/432#discussion_r342750857
 
 

 ##########
 File path: src/ports/postgres/modules/lda/lda.py_in
 ##########
 @@ -208,15 +232,19 @@ class LDATrainer:
                             doc_topic[{topic_num} + 1:array_upper(doc_topic, 1)],
                             {voc_size},
                             {topic_num}
-                        ) AS model
+                        ) AS model,
 
 Review comment:
   1. Adding a comma after `model` makes the query syntactically wrong since n_iterations already has a comma at the end.
   1. Adding a comma after `perplexity_iterations` will also make the syntax invalid since there will be a comma right before the FROM clause

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services