You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Anthony Abate (JIRA)" <ji...@apache.org> on 2008/10/23 23:22:44 UTC
[jira] Created: (THRIFT-181) SSL Support
SSL Support
-----------
Key: THRIFT-181
URL: https://issues.apache.org/jira/browse/THRIFT-181
Project: Thrift
Issue Type: New Feature
Components: Library (C#)
Environment: VS 2008
Reporter: Anthony Abate
I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-181) C# SSL Support
Posted by "Anthony Abate (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658993#action_12658993 ]
Anthony Abate commented on THRIFT-181:
--------------------------------------
This was never intended to be merged directly into thrift, but it was meant to start the ball rolling.
I never heard anything so I assumed it got lost backlog of tickets as there doesn't really seem to be much momentum on the C# side in thrift.
log4net is pretty ubiquitous, and I suspect that anyone who doesn't like this dependency can easily modify that. The original TServerSocket.cs code used "Console.Error" which did not serve my needs.
The TODO refers to 2 way certificate look ups. That is, the client will also have a certificate that is verified by the server. Most times, the client just verifies the server as in https because its impossible for public websites to know each client that connects.. I personally do not need this feature, nor do most people, so I left it out but indicated where it would be implemented if needed.
What information should I supply? Its used inplace of TSocket and TServerSocket. You just need to supply a certificate.
> C# SSL Support
> --------------
>
> Key: THRIFT-181
> URL: https://issues.apache.org/jira/browse/THRIFT-181
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Environment: VS 2008
> Reporter: Anthony Abate
> Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-181) C# SSL Support
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658962#action_12658962 ]
Michael Greene commented on THRIFT-181:
---------------------------------------
I haven't had a chance to use these classes, but speaking to the code:
* The TODOs shouldn't enter the codebase. If they still need to be done, they should be taken care of before these patches are accepted.
* -1 for author information
* -1 for dependency on log4net. One way you can get around this is by allowing a logger delegate a la THRIFT-25.
* The spacing should be done in tabs to match the existing library.
I do think SSL is something sorely lacking in the C# implementation and would like to see this further developed. This is a great start.
> C# SSL Support
> --------------
>
> Key: THRIFT-181
> URL: https://issues.apache.org/jira/browse/THRIFT-181
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Environment: VS 2008
> Reporter: Anthony Abate
> Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-181) SSL Support
Posted by "Anthony Abate (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Abate updated THRIFT-181:
---------------------------------
Attachment: TSSLServerSocket.cs
SSL Socket Server
> SSL Support
> -----------
>
> Key: THRIFT-181
> URL: https://issues.apache.org/jira/browse/THRIFT-181
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Environment: VS 2008
> Reporter: Anthony Abate
> Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-181) SSL Support
Posted by "Anthony Abate (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Abate updated THRIFT-181:
---------------------------------
Attachment: TSSLSocket.cs
SSL Socket
> SSL Support
> -----------
>
> Key: THRIFT-181
> URL: https://issues.apache.org/jira/browse/THRIFT-181
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Environment: VS 2008
> Reporter: Anthony Abate
> Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-181) C# SSL Support
Posted by "James E. King, III (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896933#action_12896933 ]
James E. King, III commented on THRIFT-181:
-------------------------------------------
There is a SSL implementation with full certificate support in the patch I uploaded for THRIFT-66. It is not attached here because the C# runtime was overhauled a fair amount by the patch and TTransport changed slightly to accomodate new logging functions.
> C# SSL Support
> --------------
>
> Key: THRIFT-181
> URL: https://issues.apache.org/jira/browse/THRIFT-181
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Environment: VS 2008
> Reporter: Anthony Abate
> Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-181) C# SSL Support
Posted by "Jeff Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795245#action_12795245 ]
Jeff Brown commented on THRIFT-181:
-----------------------------------
Please don't take a dependency on log4net. I'm in a position where I have to take as few dependencies as possible because my code (Gallio / MbUnit) may be linked with other people's arbitrary code that might have different conflicting dependencies. I'm even considering internalizing Thrift.dll using ILMerge...
So I second adding a very basic logging interface or delegate that clients can wire up as needed.
> C# SSL Support
> --------------
>
> Key: THRIFT-181
> URL: https://issues.apache.org/jira/browse/THRIFT-181
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Environment: VS 2008
> Reporter: Anthony Abate
> Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-181) C# SSL Support
Posted by "Anthony Abate (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Abate updated THRIFT-181:
---------------------------------
Summary: C# SSL Support (was: SSL Support)
> C# SSL Support
> --------------
>
> Key: THRIFT-181
> URL: https://issues.apache.org/jira/browse/THRIFT-181
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Environment: VS 2008
> Reporter: Anthony Abate
> Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.