You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by csantanapr <gi...@git.apache.org> on 2016/03/25 21:21:10 UTC
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/416
CB-10961 Error when adding ios platform and plugin declare in config.xml
@vladimir-kotikov can you review
This other commit https://github.com/apache/cordova-lib/commit/3b9face5187857d354d85f3e3f4316cbace100db
changing the order to run prepare after plugin install cause the problem. I added a prepare before, and left the prepare on after plugin install.
I don't think there is harm on running prepare twice on platform add
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-lib CB-10961
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit 9359d3b421a323601ea62587cab19bfad8690fb7
Author: Carlos Santana <cs...@gmail.com>
Date: 2016-03-25T20:17:01Z
CB-10961 Error no such file or directory adding ios platform when plugins present or required
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201929790
@csantanapr, this LGTM and i believe it would solve the problem, but I think the real problem is in cordova-ios `prepare` method - when you change app's name this change doesn't reflected to ios `Api`'s properties (see [prepare.js#L189-L191](https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L189-L191)), and when you call `Api` next time, it uses the old project's path.
It looks like https://github.com/apache/cordova-lib/commit/3b9face5187857d354d85f3e3f4316cbace100db that you mentioned just uncovered the real problem.
If you think this is urgent, we could merge this and do 6.1.1 release but i'd like to fix this in iOS instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-202818205
@csantanapr, i merged a bit different change, which uses `preparePlatforms` method instead of `prepare` .It is a subset of `prepare` but doesn't include the actions that are not expected to ran at this moment, like restoring platforms, plugins, fire hooks. Tested it with the case described in JIRA and it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201881251
@riknoll I don't think is big deal if prepare hooks twice, I will look to see if there is a way to call first prepare without hooks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201937380
@vladimir-kotikov yes lets fix this in cordova-lib to get a fix in CLI 6.1.1, but I agree with you that problem should also be fix in iOS
The root of the problem is the merge of XML the <name> value from project config.xml doesn't overwrite the <name> in default platform config.xml <name> I open the JIRA [CB-10965](https://issues.apache.org/jira/browse/CB-10965)
The real problem is cordova-common merge util where i think the tag name should be single instance in result of merge https://github.com/apache/cordova-lib/blob/master/cordova-common/src/util/xml-helpers.js#L197
similar as author and description.
it will require a cordova-common release, then an iOS to pick up the change. But I think fixing in CLI 6.1.1 is required to not brake other ios platforms versions that don't have this fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201642371
Does running prepare twice have any impact on the hooks that fire?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201893339
@riknoll @vladimir-kotikov I found a way to skip prepare hooks on first prepare call. made the change I rebase, please review again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org