You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/07 16:30:20 UTC
[GitHub] [incubator-doris] morningman opened a new pull request, #10005: [improvement][refactor](image) refactor the read and load method of meta image
morningman opened a new pull request, #10005:
URL: https://github.com/apache/incubator-doris/pull/10005
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
In #6207, we change the meta image format, add header and footer to save some information about the image file,
so that we can more easily read data in it.
This CL mainly changes:
1. Move all image read and write class to a new package `org.apache.doris.persist.meta`
2. Refactor the MetaReader and MetaWriter, so that we can easier to add new meta modules in image.
3. Read the meta module in image using the information saved in meta footer, so that we are able to add new modules without changing the FeMetaVersion.
This CL **does not change any content or format of the image file**. Just the modify the read and write method of it.
## Checklist(Required)
1. Does it affect the original behavior: (No)
5. Has unit tests been added: (Yes)
6. Has document been added or modified: (No Need)
7. Does it need to update dependencies: (No)
8. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #10005: [improvement][refactor](image) refactor the read and load method of meta image
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10005:
URL: https://github.com/apache/incubator-doris/pull/10005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10005: [improvement][refactor](image) refactor the read and load method of meta image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10005:
URL: https://github.com/apache/incubator-doris/pull/10005#issuecomment-1152034998
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10005: [improvement][refactor](image) refactor the read and load method of meta image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10005:
URL: https://github.com/apache/incubator-doris/pull/10005#issuecomment-1152035026
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #10005: [improvement][refactor](image) refactor the read and load method of meta image
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10005:
URL: https://github.com/apache/incubator-doris/pull/10005#issuecomment-1151802251
> LGTM. I just didn't get why do we refactor the MetaReader and MetaWriter code. Using reflection makes it a little bit harder to read the code. But it's not a block, just curious.
For 2 reason:
1. Use information saved in MetaFooter to load the image, so that we can skip some newly added modules, for forward compatibility.2
2. Use reflect so that we don't need to modify MetaReader and MetaWriter anymore in future, only need to add new method in MetaPersiteMethod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org