You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by suresh sadhu <ma...@gmail.com> on 2015/03/26 13:53:14 UTC
Re: Review Request 30661: LDAP:automation:added missing scenrio and
additional checks for better debugging
> On Feb. 13, 2015, 7:31 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_ldap.py, line 82
> > <https://reviews.apache.org/r/30661/diff/1/?file=850400#file850400line82>
> >
> > It is better to skip the test when there are no required fields.
initially though to skip the tests in setup class it self but later realized if it fail to address the negative scenario so removed the skip test part.
- suresh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30661/#review72341
-----------------------------------------------------------
On Feb. 19, 2015, 12:04 p.m., suresh sadhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30661/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2015, 12:04 p.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8218
> https://issues.apache.org/jira/browse/CLOUDSTACK-8218
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> added missing scenrio and additional checks for better debugging
>
>
> Diffs
> -----
>
> test/integration/component/test_ldap.py 3464022
>
> Diff: https://reviews.apache.org/r/30661/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> suresh sadhu
>
>