You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/12/27 09:24:28 UTC

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3547: [SCB-2742]change IsolationDiscoveryFilter enabled by false

liubao68 opened a new pull request, #3547:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3547

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3547: [SCB-2742]change IsolationDiscoveryFilter enabled by false

Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3547:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3547


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3547: [SCB-2742]change IsolationDiscoveryFilter enabled by false

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3547:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3547#issuecomment-1366452989

   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3547](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da37f5b) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/1105e936e47572a85ff1d9f326765f65e3153088?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1105e93) will **increase** coverage by `0.00%`.
   > The diff coverage is `79.41%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             master    #3547    +/-   ##
   ==========================================
     Coverage     74.39%   74.40%            
   - Complexity      670      680    +10     
   ==========================================
     Files          1589     1590     +1     
     Lines         39827    39935   +108     
     Branches       3633     3650    +17     
   ==========================================
   + Hits          29631    29713    +82     
   - Misses         8716     8733    +17     
   - Partials       1480     1489     +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...y/registry/cache/RefreshableMicroserviceCache.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3JlZ2lzdHJ5L2NhY2hlL1JlZnJlc2hhYmxlTWljcm9zZXJ2aWNlQ2FjaGUuamF2YQ==) | `89.62% <16.66%> (-0.10%)` | :arrow_down: |
   | [...egistry/cache/RefreshableServiceRegistryCache.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L3JlZ2lzdHJ5L2NhY2hlL1JlZnJlc2hhYmxlU2VydmljZVJlZ2lzdHJ5Q2FjaGUuamF2YQ==) | `77.04% <64.28%> (-6.29%)` | :arrow_down: |
   | [...e/servicecomb/demo/edge/consumer/ConsumerMain.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWVkZ2UvY29uc3VtZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vZWRnZS9jb25zdW1lci9Db25zdW1lck1haW4uamF2YQ==) | `86.36% <71.42%> (-6.97%)` | :arrow_down: |
   | [.../demo/edge/consumer/EdgeServiceGovernanceTest.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWVkZ2UvY29uc3VtZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vZWRnZS9jb25zdW1lci9FZGdlU2VydmljZUdvdmVybmFuY2VUZXN0LmphdmE=) | `87.67% <87.67%> (ø)` | |
   | [...comb/loadbalance/ServiceCombLoadBalancerStats.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2VydmljZUNvbWJMb2FkQmFsYW5jZXJTdGF0cy5qYXZh) | `82.43% <100.00%> (ø)` | |
   | [...oadbalance/filterext/IsolationDiscoveryFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZmlsdGVyZXh0L0lzb2xhdGlvbkRpc2NvdmVyeUZpbHRlci5qYXZh) | `92.85% <100.00%> (ø)` | |
   | [...ecomb/foundation/common/utils/SPIServiceUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL1NQSVNlcnZpY2VVdGlscy5qYXZh) | `92.85% <0.00%> (-1.79%)` | :arrow_down: |
   | [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `9.57% <0.00%> (-1.07%)` | :arrow_down: |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `68.26% <0.00%> (-0.39%)` | :arrow_down: |
   | [...b/core/provider/producer/ProducerBootListener.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9wcm92aWRlci9wcm9kdWNlci9Qcm9kdWNlckJvb3RMaXN0ZW5lci5qYXZh) | `64.86% <0.00%> (+3.32%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org