You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2025/09/24 22:40:32 UTC
Re: [PR] [SPARK-53703] Improve unit tests to be neutral from Spark versions [spark-kubernetes-operator]
dongjoon-hyun commented on code in PR #339:
URL: https://github.com/apache/spark-kubernetes-operator/pull/339#discussion_r2377234275
##########
spark-operator-api/src/test/resources/spark-job-with-driver-service-ingress.json:
##########
@@ -1,15 +1,6 @@
{
- "mainClass": "org.apache.spark.examples.SparkPi",
- "jars": "local:///opt/spark/examples/jars/spark-examples.jar",
- "sparkConf": {
- "spark.kubernetes.driver.master": "local[10]",
- "spark.kubernetes.driver.request.cores": "5",
- "spark.kubernetes.driver.limit.cores": "5",
- "spark.kubernetes.authenticate.driver.serviceAccountName": "spark",
- "spark.kubernetes.container.image": "apache/spark:4.0.0"
- },
Review Comment:
This test resource is used for `Driver Service Ingress` test case. So, the removed information are irrelevant and not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org