You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2025/05/12 02:20:31 UTC
[PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Gabriel39 opened a new pull request, #50796:
URL: https://github.com/apache/doris/pull/50796
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870712954
<details>
<summary>ClickBench: <b>Total hot run time: 30.01 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 235c8dafa4d8c6030b1b500a29d2f5df6add227d, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.10 0.12
query3 0.25 0.20 0.19
query4 1.60 0.19 0.19
query5 0.60 0.59 0.59
query6 1.19 0.71 0.73
query7 0.02 0.02 0.01
query8 0.05 0.03 0.04
query9 0.57 0.51 0.51
query10 0.57 0.58 0.56
query11 0.16 0.12 0.11
query12 0.14 0.12 0.12
query13 0.61 0.60 0.61
query14 0.79 0.81 0.80
query15 0.88 0.85 0.85
query16 0.38 0.38 0.38
query17 1.00 1.02 1.08
query18 0.24 0.22 0.23
query19 1.91 1.85 1.86
query20 0.02 0.01 0.01
query21 15.39 0.92 0.54
query22 0.76 1.21 0.65
query23 14.95 1.38 0.64
query24 6.68 1.29 1.39
query25 0.52 0.18 0.13
query26 0.61 0.16 0.14
query27 0.06 0.05 0.05
query28 10.21 0.86 0.45
query29 12.56 3.98 3.34
query30 0.28 0.10 0.07
query31 2.82 0.58 0.39
query32 3.23 0.56 0.47
query33 3.09 3.09 3.08
query34 15.81 5.15 4.54
query35 4.52 4.54 4.58
query36 0.67 0.51 0.48
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.18 0.14 0.14
query41 0.09 0.03 0.03
query42 0.04 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 103.82 s
Total hot run time: 30.01 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870903360
# BE UT Coverage Report
Increment line coverage `19.38% (44/227)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/235c8dafa4d8c6030b1b500a29d2f5df6add227d_235c8dafa4d8c6030b1b500a29d2f5df6add227d/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/235c8dafa4d8c6030b1b500a29d2f5df6add227d_235c8dafa4d8c6030b1b500a29d2f5df6add227d/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.76% (14894/26709) |
| Line Coverage | 44.58% (131784/295636) |
| Region Coverage | 43.63% (66269/151881) |
| Branch Coverage | 38.23% (33956/88814) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870963113
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870678975
<details>
<summary>TPC-H: <b>Total hot run time: 34107 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 235c8dafa4d8c6030b1b500a29d2f5df6add227d, data reload: false
------ Round 1 ----------------------------------
q1 26349 5064 4999 4999
q2 2070 270 184 184
q3 10397 1241 691 691
q4 10226 1004 531 531
q5 7529 2391 2319 2319
q6 181 166 134 134
q7 924 777 635 635
q8 9326 1298 1154 1154
q9 6955 5052 5048 5048
q10 6865 2333 1886 1886
q11 475 292 278 278
q12 350 350 227 227
q13 17795 3687 3106 3106
q14 232 228 209 209
q15 527 494 502 494
q16 434 429 382 382
q17 627 871 376 376
q18 7517 7235 7172 7172
q19 2054 960 571 571
q20 346 346 232 232
q21 4205 3338 2502 2502
q22 1085 1041 977 977
Total cold run time: 116469 ms
Total hot run time: 34107 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5300 5099 5133 5099
q2 238 327 237 237
q3 2204 2646 2278 2278
q4 1362 1832 1444 1444
q5 4468 4431 4337 4337
q6 210 168 127 127
q7 2016 1929 1740 1740
q8 2626 2572 2521 2521
q9 7248 7076 7053 7053
q10 3048 3180 2742 2742
q11 586 526 484 484
q12 726 776 627 627
q13 3514 3884 3345 3345
q14 305 317 270 270
q15 534 473 464 464
q16 434 498 459 459
q17 1187 1596 1402 1402
q18 7781 7642 7513 7513
q19 800 817 908 817
q20 1965 1967 1855 1855
q21 5139 4859 4678 4678
q22 1099 1053 1015 1015
Total cold run time: 52790 ms
Total hot run time: 50507 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870963043
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870941151
# BE Regression && UT Coverage Report
Increment line coverage `83.70% (190/227)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50796_235c8dafa4d8c6030b1b500a29d2f5df6add227d_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50796_235c8dafa4d8c6030b1b500a29d2f5df6add227d_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.30% (20837/26275) |
| Line Coverage | 72.52% (214346/295572) |
| Region Coverage | 70.66% (126044/178381) |
| Branch Coverage | 64.40% (65313/101422) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #50796:
URL: https://github.com/apache/doris/pull/50796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870535266
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870540188
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](minor) Rename `DataTypeObject` and `ColumnObject` [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50796:
URL: https://github.com/apache/doris/pull/50796#issuecomment-2870691445
<details>
<summary>TPC-DS: <b>Total hot run time: 193325 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 235c8dafa4d8c6030b1b500a29d2f5df6add227d, data reload: false
query1 1421 1125 1096 1096
query2 6216 1791 1800 1791
query3 11174 4731 4510 4510
query4 53681 26000 22878 22878
query5 5065 509 448 448
query6 323 206 200 200
query7 4875 533 297 297
query8 326 252 240 240
query9 5320 2671 2687 2671
query10 440 333 280 280
query11 14963 15039 14919 14919
query12 168 112 106 106
query13 1014 522 421 421
query14 10273 6412 6476 6412
query15 206 206 180 180
query16 7100 652 523 523
query17 1086 774 594 594
query18 1574 435 331 331
query19 215 206 174 174
query20 130 143 121 121
query21 209 133 116 116
query22 4315 4372 4275 4275
query23 34558 33427 33638 33427
query24 6691 2420 2500 2420
query25 465 483 410 410
query26 736 272 151 151
query27 2363 514 339 339
query28 2886 2161 2165 2161
query29 592 571 433 433
query30 277 240 190 190
query31 853 857 778 778
query32 71 65 64 64
query33 454 365 325 325
query34 796 866 545 545
query35 800 873 799 799
query36 943 981 900 900
query37 110 99 103 99
query38 4307 4256 4224 4224
query39 1519 1438 1462 1438
query40 214 121 107 107
query41 55 57 50 50
query42 123 117 109 109
query43 504 520 493 493
query44 1357 875 875 875
query45 186 173 172 172
query46 872 1040 665 665
query47 1835 1854 1781 1781
query48 399 433 312 312
query49 686 524 426 426
query50 686 724 437 437
query51 4355 4367 4190 4190
query52 111 107 103 103
query53 228 258 190 190
query54 606 594 516 516
query55 88 85 87 85
query56 344 310 328 310
query57 1166 1156 1145 1145
query58 264 258 258 258
query59 2642 2723 2573 2573
query60 343 337 324 324
query61 131 130 124 124
query62 731 730 679 679
query63 229 220 198 198
query64 1805 1053 720 720
query65 4380 4241 4203 4203
query66 716 414 301 301
query67 16124 15642 15403 15403
query68 7535 884 517 517
query69 543 306 269 269
query70 1222 1107 1127 1107
query71 526 330 304 304
query72 5756 4799 4953 4799
query73 1325 635 354 354
query74 9452 9139 8899 8899
query75 3780 3234 2766 2766
query76 4179 1208 768 768
query77 632 358 282 282
query78 10110 10192 9399 9399
query79 2167 829 591 591
query80 662 508 463 463
query81 482 262 217 217
query82 424 125 96 96
query83 264 248 234 234
query84 292 115 83 83
query85 775 354 320 320
query86 396 316 258 258
query87 4549 4607 4466 4466
query88 3258 2327 2332 2327
query89 403 309 287 287
query90 1795 214 220 214
query91 148 147 111 111
query92 72 59 56 56
query93 1777 957 577 577
query94 672 463 305 305
query95 376 304 282 282
query96 491 587 287 287
query97 3170 3260 3189 3189
query98 233 202 197 197
query99 1422 1400 1266 1266
Total cold run time: 298583 ms
Total hot run time: 193325 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org