[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11156: Fix compatibility test

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #11156:
URL: https://github.com/apache/pinot/pull/11156#discussion_r1271882974


##########
.github/workflows/scripts/.pinot_compatibility_verifier.sh:
##########
@@ -61,12 +61,12 @@ echo "</settings>">> ${SETTINGS_FILE}
 # PINOT_MAVEN_OPTS is used to provide additional maven options to the checkoutAndBuild.sh command
 export PINOT_MAVEN_OPTS="-s $(pwd)/${SETTINGS_FILE}"
 
-if [ -z "$newerCommit" ]; then
-  echo "Running compatibility regression test against \"${olderCommit}\""
+if [ -z "${NEW_COMMIT}" ]; then
+  echo "Running compatibility regression test against \"${OLD_COMMIT}\""
   compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT
 else
-  echo "Running compatibility regression test against \"${olderCommit}\" and \"${newerCommit}\""
-  compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT -n $NEW_OLD_COMMIT
+  echo "Running compatibility regression test against \"${OLD_COMMIT}\" and \"${NEW_COMMIT}\""
+  compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT -n $NEW_COMMIT

Review Comment:
   Interesting, this has been here for a long while



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org